Repository navigation
feat(audit-log): filter from an entry's detail, name members, show where it came from - #2423
Conversation
…lookup filters The audit log listed every telemetry read and MCP tool call beside the changes, so the entries an admin opens the page for were buried. The list now opens on Changes (data access hidden unless it was denied), with Data access and All one click away, backed by a new kind param on GET /v2/audit_log. Also: resource type, action and affected user filters, a lookup field that turns a pasted id or action into its filter, chips for filters with no control of their own, a working Custom range, and a /lab/audit-log page over fixtures.
…ere it came from Following a trail meant copying an id and pasting it back as a filter. Every actor, action, resource, affected user and request in an entry's detail now has a Filter action that lists every entry with that value. Also: unnamed actors and membership changes show the member's name, a new Origin section shows surface, IP, country and request, metadata keys read as labels, and each entry has a link that opens the log on it (?entry=alog_...) and scrolls it into view. inlineCode gains size and tone options; the audit log detail and the alerts hub empty state move onto them, clearing 6 ui-kit baseline violations.
This comment has been minimized.
This comment has been minimized.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 28 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
![maple-review-bot[bot]](https://avatars.githubusercontent.com/in/4108169?s=60&v=4){kind=small}
… minute was The link listed the minute around the entry, newest first, so 50 newer entries pushed it to page 2 where it never opened. The window now ends at the entry, which therefore heads the first page, and a later page holding it reveals it too.
This comment has been minimized.
This comment has been minimized.
|
F2 (no test for dropping |
This comment has been minimized.
This comment has been minimized.
…filters # Conflicts: # apps/web/src/route/search.ts
This comment has been minimized.
This comment has been minimized.
The Origin section was skipped when an entry had no IP, country or request id, which also hid the surface it always has. Adds a test for that, and one for the window an entry's link opens.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…e-minute window An entry link lists the minute ending at its entry. A pivot kept that custom range, so "every entry with this actor" listed only that minute.
Maple review🟢 Confidence 10/10 · safe to merge. Each new behavior (pivots, reveal, member names, origin) has a scene test, and the entry-link pivot fix is pinned by a URL assertion. Adds Filter pivots from an entry's detail, member names for unnamed actors and membership changes, an Origin section, and a per-entry link that expands and scrolls to its entry; a filter change now also drops Fixed since the last review
|
Part 2 of 3 of the audit log UI polish. Stacked on #2422.
Following a trail through the audit log meant copying an ID and pasting it back as a filter. Now every actor, action, resource, affected user and request in an entry's detail has a Filter action that lists every entry with that value. Filtering by an actor clears the actor-type filter; filtering by an action also picks its resource type, so the action select shows it.
user_…ID.row_count,display_name.?entry=alog_…), even if it arrives on a later page. Any filter change drops the link param.inlineCodegainssizeandtoneoptions. The audit log detail and the alerts hub empty state move onto them, clearing 6 ui-kit baseline violations.Before / after
Member names in the list ("Member · Linus Torvalds", Linus as actor):
Verification
audit-log.scene.test.ts: an unnamed actor is named from memberships, actor and action pivots produce the right URLs, a shared entry link expands its entry and issues the scroll, including when it arrives on a later page, the Origin section names the country (17 pass).apps/webandpackages/viewstypecheck; oxlint is clean;lint:ui-baselineshrank 733 → 727.Stack: #2422 → #2423 (this) → #2424
🤖 Generated with Claude Code