Make GFXRECON_LOG_FATAL actually fatal on non-Android platforms#2986
Open
fabian-lunarg wants to merge 14 commits into
Open
Make GFXRECON_LOG_FATAL actually fatal on non-Android platforms#2986fabian-lunarg wants to merge 14 commits into
fabian-lunarg wants to merge 14 commits into
Conversation
fabian-lunarg
added
the
approved-to-run-ci
Contributor
Author
fabian-lunarg
force-pushed
the
fabian_make_log_fatal_fatal_again
branch
3 times, most recently
from
41dbd0e to
c899215
Compare
MarkY-LunarG
approved these changes
Jun 2, 2026
fabian-lunarg
force-pushed
the
fabian_make_log_fatal_fatal_again
branch
2 times, most recently
from
7d071a4 to
add4957
Compare
fabian-lunarg
commented
Jun 9, 2026
fabian-lunarg
force-pushed
the
fabian_make_log_fatal_fatal_again
branch
from
add4957 to
9a51d9e
Compare
fabian-lunarg
force-pushed
the
fabian_make_log_fatal_fatal_again
branch
8 times, most recently
from
860c18e to
bbb4f8b
Compare
- Add Log::SetFatalCallback(): on kFatal, invoke the callback or abort() if none is set. - Remove the copy-pasted fatal_error_handler_/RaiseFatalError pattern from all four replay consumer classes, tools set the callback once to throw std::runtime_error instead. # Conflicts: # tools/replay/android_main.cpp # tools/replay/desktop_main.cpp
…been disabled" - we obviously want to continue, so FATAL was wrong severity
… open failure to ERROR # Conflicts: # framework/decode/vulkan_replay_consumer_base.cpp
- logs were not fatal before, not followed by an abort/exit.
- abort() is called regardless of whether a fatal_callback_ is set - Log::Release() clears the callback, removing the need for manual resets - unit test for callback invocation updated
- trying to maintain previous behavior
fabian-lunarg
force-pushed
the
fabian_make_log_fatal_fatal_again
branch
from
bbb4f8b to
52ebe95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log::SetFatalCallback(): onkFatal, invoke the callback, followed by a catch-allstd::abort().fixes #1024