Run the file half in the browser stack and prove the photo flow end to end - #31
Conversation
…oto flow end to end in a browser suite
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @LucaCappelletti94, you've used your own review budget of 250,000 diff characters for the last 7 days.
You can request another review in 4 days and 1 hour by commenting @sourcery-ai review. Upgrade to get a review now.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository: LucaCappelletti94/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Reviewer's GuideThe PR completes the R69 browser-stack wiring by provisioning the file-server schema and content store, launching the real connetto-server content listener, extending worker upstream subscriptions for photos, and adding an end-to-end wasm smoke test that stages, commits, resolves, and fetches a JPEG through the shipped binary. Sequence diagram for the browser photo content flowsequenceDiagram
actor Tab
participant Worker as DBWorker
participant Relay as RelayHub
participant Server as ConnettoServer
participant Store as FileStore
Tab->>Worker: db_worker_photo_boot()
Worker->>Relay: subscribe(db-upstream, DEMO_QUERY)
Worker->>Relay: subscribe(db-photos-upstream, PHOTO_QUERY)
Tab->>Worker: stage JPEG with orders and photos rows
Worker->>Relay: commit transaction
Relay-->>Worker: content_state available
Tab->>Worker: resolve content
Worker->>Server: resolve signed URL
Server-->>Worker: signed URL
Tab->>Server: fetch JPEG
Server->>Store: read content
Store-->>Server: JPEG bytes
Server-->>Tab: JPEG bytes
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
=======================================
Coverage 83.27% 83.27%
=======================================
Files 114 114
Lines 25693 25693
Branches 25693 25693
=======================================
Hits 21396 21396
Misses 3073 3073
Partials 1224 1224
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
1 participant
This closes the leftover half of R69 step A. The browser stack now applies the file server deployment DDL and the wasm-smoke content.sql in the documented order, and spawns the real connetto-server with the content settings so the four file routes run in the shipped binary on its own listener at 127.0.0.1:18100, with a fresh Ed25519 DER ticket key, a temp file store swept every second, and CONNETTO_TEST_CONTENT_BASE handed to the suites.
Driving the flow for the first time exposed one real gap worth recording for D, E and F. The relay hub answers a tab row subscription from the worker replica and only records its tables for routing, only aggregates mint a private upstream subscription, so a table a tab must see live has to be in the worker's own upstream subscription set. DbWorkerConfig gains an additive with_extra_upstream builder, default empty and every existing boot byte-identical, and wasm-smoke gains a photo worker boot subscribing over photos next to orders.
The new examples/wasm-smoke/tests/photo_flow.rs is the first browser test a human could demo by hand. A tab stages a JPEG through the worker inside one transaction with the orders and photos rows, waits for the mirrored content_state to flip to available, a write only the server commit can make, resolves through the worker to a signed URL on the real listener and fetches the bytes back equal. The whole local browser stack run passed, 44 suites plus verified_topology, with stable and nightly clippy and fmt clean in the root, connetto-web and wasm-smoke workspaces. The plan status row for R69 now reads IN PROGRESS with D, E and F open.
Summary by Sourcery
Prove the browser photo flow end to end by wiring the file-serving half into the browser stack and allowing workers to subscribe to additional upstream tables.
New Features:
Bug Fixes:
Enhancements:
Documentation:
Tests: