fix(nodes): remove misleading aggregate SNR headlines - #1969
Conversation
|
Merging. CI had never run on this (stuck in Removing the aggregate is the right call rather than trying to caveat it. An average SNR over every observer that heard a node is a number without a referent: it mixes a receiver 500 m away with one 40 km away, so it moves when the observer mix changes and not when the node's RF situation does. Keeping the per-observer "Heard By" readings, which each mean something on their own, and dropping the single figure that means nothing is the correct trade. Verified the fixtures keep SNR non-null, so the test proves the field is deliberately not rendered rather than passing because there was nothing to render. That is the difference between this test and a vacuous one. |
Red commit:
2bf9be8(local Chromium: 3 passed, 3 intended assertion failures). CI: run awaits maintainer approval (action_required); 0 jobs started.Remove the unqualified aggregate Avg SNR row from node side-panel Overview and full-detail stats, following option 3 in #1149. Heard By retains each observer's SNR reading.
Fixes #1149.
test-issue-1281-location-row-e2e.js:224. Three new browser cases cover desktop side/full and mobile full views with a numeric aggregate and distinct positive/negative observer readings. Existing packet-location assertions remain intact.coverage/issue-1149/issue-1149-desktop-side-panel.png,coverage/issue-1149/issue-1149-desktop-full-detail.png, andcoverage/issue-1149/issue-1149-mobile-full-detail.png.Fix commit:
d7c68f3.Preflight overrides
run-all.shis unavailable on this host. Scoped branch, red/green, PII, CSS, XSS and whitespace checks were run directly. The diff adds no migrations, SQL attribution or image markup.