fix(nodes): clearly mark the selected node in path chains - #1968
Conversation
|
Merging. CI had never run on this (stuck in The actual bug is the case comparison, and it is worth naming plainly: Moving the inline Checked the combination rather than this PR alone: merged together with #1969 and #1970 onto current master it applies cleanly, the three touch disjoint hunks, eslint is clean and the frontend helper suite is 666 passed 0 failed. Three green PRs on one file are each green against a master that does not contain the other two, so that seemed worth confirming before merging any of them. |
Red commit:
0988bc0(local browser: 3 passed, 8 behavior assertion failures before the fix).The selected node now has a compact outline in long “Paths Through This Node” chains, in the side panel and full detail page. Matching uses complete public keys without case sensitivity; same-prefix siblings and unresolved hops stay unmarked. Existing links, escaped names, warnings and ambiguity underlines are preserved.
Fixes #1153. Its prerequisite #1144 is already merged.
test-issue-1146-path-link-contrast-e2e.js:220. The existing CI-selected harness passes 11 checks across 18-hop paths, both themes, desktop/mobile, and the renderer fallback. Review follow-upbd8118fverifies the marked ambiguous hop's dashed underline.http://127.0.0.1:55635; desktop/mobile path screenshots were inspected. The broader smoke runner exited successfully with fixture-dependent skips.Preflight overrides