Index PhyslibAlpha and QuantumInfo, not just Physlib - #28
Merged
Conversation
PhysLib's lakefile declares three Lean libraries -- Physlib, PhyslibAlpha and QuantumInfo -- but MODULE_NAMES only listed Physlib, so roughly 130 of its ~620 source files were never indexed and never appeared in search. Two changes are needed, because jixia analyses .olean files rather than sources: index all three namespaces, and build all three. PhyslibAlpha is absent from the lakefile's defaultTargets, so plain 'lake build' never compiled it -- pass MODULE_NAMES to lake explicitly. Raise the build timeout to 120 min to cover the extra libraries on a cold cache. Also assert per-namespace module counts after the load. A library that fails to build yields no modules rather than an error, so without this check a namespace can disappear from the index silently -- which is exactly how PhyslibAlpha stayed missing while every run reported success.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PhysLib's lakefile declares three Lean libraries:
MODULE_NAMESonly listedPhyslib, so roughly 130 of ~620 source files (~47 in PhyslibAlpha, ~84 in QuantumInfo) were never indexed and have never appeared in search.Note: the recent runs are not failing — the last 7 scheduled runs all succeeded. The pipeline was healthy; it was just indexing a subset of the library.
What
Two changes, because jixia analyses
.oleanfiles rather than sources:MODULE_NAMES: Physlib,PhyslibAlpha,QuantumInfoPhyslibAlphais absent from the lakefile'sdefaultTargets, so plainlake buildnever compiled it — jixia cannot analyse what lake never built. The build step now passesMODULE_NAMESto lake explicitly. Timeout raised 90 → 120 min for the extra libraries on a cold cache.Verified
parse_name('PhyslibAlpha.Foo')→['PhyslibAlpha', 'Foo'], confirmingname->>0extracts the namespace as the new check assumesExpect
The first run will be long — it builds two additional libraries and indexes ~130 new files through informalize and embedding.