Allow forcing a run when only our indexing config changed - #29
Merged
Conversation
Widening MODULE_NAMES to PhyslibAlpha and QuantumInfo left work to do at an unchanged PhysLib SHA, but the skip check only compares that SHA against LAST_PHYSLIB_SHA. The first run after the change therefore skipped every step and reported success in six minutes, having indexed nothing. Add a force input to workflow_dispatch that bypasses the SHA comparison, and key the lake build cache on the workflow file too -- which libraries were compiled is part of what that cache holds, so a Physlib-only build should not be restored verbatim once more libraries are in scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The first run after widening
MODULE_NAMES(#28) skipped everything and reported success in six minutes:The skip check compares PhysLib's HEAD against
LAST_PHYSLIB_SHA. That tracks PhysLib, and says nothing about whether our config changed — so widening the indexed namespaces left real work to do at an unchanged SHA, and the run declined to do it.What
forceinput onworkflow_dispatch— bypasses the SHA comparison. Use after wideningMODULE_NAMES.Physlib-only build shouldn't be restored verbatim now that two more libraries are in scope.restore-keysstill falls back to a same-SHA build, so this is a partial-reuse hint rather than a cold rebuild.