Repository navigation
Package as 1.1.1+keel2 so the build host gets the unit slots - #6
Merged
Merged
Conversation
The two unit changes merged tonight (pull requests 4 and 5) are in share/product.mk, which reaches a build through the installed package and not through this checkout. The build host runs 1.1.1+keel1, whose product.mk applies every directory under unit.d and has no removelist, conf-vars or UNITS selection, so bt-layer's UNITS override is silently ignored there and a child layer would re-run a component's conf script. No code change: this is the version the host installs so that the merged behaviour is the behaviour a build gets.
6 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two unit changes merged tonight, pull requests 4 and 5, live in
share/product.mk. A build reads that file from the installedfabpackage, not from this checkout, and the build host installs 1.1.1+keel1: noUNITSselection, no unit removelist, noconf-vars. There,bt-layer'sUNITS=override is ignored and every directory underunit.dis applied, which is exactly the re-run a child layer must not do.This is a changelog entry and nothing else, so that the host can install the merged behaviour before the first component is extracted under decision 0010.
Test plan:
tests/coverage.sh(the package carries no code change)bin/build-package --rebuild faband installed, then the three-build equivalence comparison of decision 0010 for the mariadb component