Fix unreadable founder-card title on About page#58
Merged
Conversation
The "Founded by" card sets a dark teal background and text-white, but its h2 had no color class, so the prose heading rule (--tw-prose-headings: var(--color-on-surface)) won and rendered the title near-black on the dark card — ~1.5:1 contrast, failing WCAG AA. Add text-white to the h2 so it matches the card's intended light-on-dark scheme, consistent with the paragraph's existing text-white/80.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
text-whiteto the About-page founder card<h2>.text-white, but the heading had nocolor class, so the
proseheading rule(
--tw-prose-headings: var(--color-on-surface)) won and rendered thetitle near-black on the dark card — ≈1.5:1, failing WCAG AA.
text-white/80; one class, overridesthe prose rule by source order.
Deploy status
2026-05-16). This PR exists to bring
masterback in sync with what isdeployed — master is currently behind prod by this commit.
Merge ordering
Merge this PR FIRST, then #57. Both edit adjacent lines of
personal/templates/personal/about.html(line 33 here, line 32 in #57),so whichever merges second may hit a trivial conflict — resolution is to
keep both one-line changes (the
text-whiteon the h2 and thebg-primary-containertoken swap).Test plan
/about(no trailing slash) — founder title legible in light mode.