Skip to content

Use primary-container token instead of hardcoded hex on About card#57

Merged
Kanyandula merged 1 commit into
masterfrom
refactor/about-card-primary-container-token
May 16, 2026
Merged

Use primary-container token instead of hardcoded hex on About card#57
Kanyandula merged 1 commit into
masterfrom
refactor/about-card-primary-container-token

Conversation

@Kanyandula
Copy link
Copy Markdown
Owner

Summary

  • Replace bg-[#0f3d3e] on the About-page founder card with the
    bg-primary-container semantic token.
  • Removes a hardcoded-hex convention violation (CLAUDE.md: dark mode via
    CSS custom properties, no hardcoded colors).

Visual impact

  • Light mode: pixel-identical — --color-primary-container light is
    exactly #0f3d3e.
  • Dark mode: card now resolves to #1a4f50 and adapts with the
    palette instead of staying a fixed light-mode teal slab. White body
    text (text-white / text-white/80) stays ≈8.7:1 on it (AAA).
  • Template-only change; compiled CSS already contained
    .bg-primary-container, so no asset rebuild.

Coordination note

Related open PR fix/about-founder-title-contrast edits the adjacent
line (the card's <h2>). Diff contexts overlap, so depending on merge
order a trivial conflict may surface — resolution is simply keeping both
one-line changes (line 32 token swap + line 33 text-white).

Test plan

  • Load /about in light mode — founder card unchanged.
  • Toggle dark mode — card background adapts (teal #1a4f50), title
    and body remain readable.

The founder card hardcoded bg-[#0f3d3e], violating the "dark mode via
CSS custom properties, no hardcoded colors" convention and pinning the
card to a fixed light-mode teal that never adapts in dark mode.

#0f3d3e is exactly the light value of --color-primary-container, so
light mode is pixel-identical; dark mode now resolves to #1a4f50 and
the card adapts with the rest of the palette (white body text stays
well above WCAG AA on it).
@Kanyandula Kanyandula merged commit f610d2a into master May 16, 2026
9 checks passed
@Kanyandula
Copy link
Copy Markdown
Owner Author

Merge ordering: merge #58 before this PR.

#58 (fix/about-founder-title-contrast) is already live in production
and only needs master to catch up; it edits line 33 of
personal/templates/personal/about.html while this PR edits line 32.
Overlapping diff context means whichever merges second may hit a trivial
conflict — resolve by keeping both one-line changes (text-white on
the <h2> from #58 + bg-primary-container here).

Kanyandula added a commit that referenced this pull request May 16, 2026
Resolve about.html founder-card conflict by keeping both changes:
bg-primary-container token (from #57 on master) and text-white on the
h2 (this branch / #58).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant