Use primary-container token instead of hardcoded hex on About card#57
Merged
Merged
Conversation
The founder card hardcoded bg-[#0f3d3e], violating the "dark mode via CSS custom properties, no hardcoded colors" convention and pinning the card to a fixed light-mode teal that never adapts in dark mode. #0f3d3e is exactly the light value of --color-primary-container, so light mode is pixel-identical; dark mode now resolves to #1a4f50 and the card adapts with the rest of the palette (white body text stays well above WCAG AA on it).
2 tasks
Owner
Author
|
Merge ordering: merge #58 before this PR. #58 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bg-[#0f3d3e]on the About-page founder card with thebg-primary-containersemantic token.CSS custom properties, no hardcoded colors).
Visual impact
--color-primary-containerlight isexactly
#0f3d3e.#1a4f50and adapts with thepalette instead of staying a fixed light-mode teal slab. White body
text (
text-white/text-white/80) stays ≈8.7:1 on it (AAA)..bg-primary-container, so no asset rebuild.Coordination note
Related open PR
fix/about-founder-title-contrastedits the adjacentline (the card's
<h2>). Diff contexts overlap, so depending on mergeorder a trivial conflict may surface — resolution is simply keeping both
one-line changes (line 32 token swap + line 33
text-white).Test plan
/aboutin light mode — founder card unchanged.#1a4f50), titleand body remain readable.