Repository navigation
Conversation
GPUArrays only uses LLVM.jl for the assume intrinsic. Import it explicitly: LLVM.jl 10 exports more from LLVM.Interop, and the only name GPUArrays needs works the same on 9.x and 10.x, so the compat can admit both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows LLVM.jl 10 next to 9. GPUArrays only uses
LLVM.Interop.assume, which didn't change. It's now imported explicitly, becauseLLVM.Interopexports more names in 10. The same change for the 11.x series, which the GPU back-ends currently depend on, is #801.Tested on Julia 1.10 and 1.12, with no failures.
Disclaimer: this PR is AI-assisted and has not been reviewed in detail. Tests pass locally, so it should be a good starting point for a maintainer to complete the upgrade.