Skip to content

Give get_effects(::MultiCallInfo) an identity for empty callinfos #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jishnub wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Give get_effects(::MultiCallInfo) an identity for empty callinfos #708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/compiler/callsite.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ struct MultiCallInfo <: CallInfo
end
get_ci(ci::MultiCallInfo) = error("Can't extract MethodInstance from multiple call informations")
get_rt(ci::MultiCallInfo) = ci.rt
get_effects(mci::MultiCallInfo) = mapreduce(get_effects, CC.merge_effects, mci.callinfos)
get_effects(mci::MultiCallInfo) = mapreduce(get_effects, CC.merge_effects, mci.callinfos; init=EFFECTS_TOTAL)
get_exct(ci::MultiCallInfo) = ci.exct

struct TaskCallInfo <: CallInfo
Expand Down
3 changes: 3 additions & 0 deletions test/test_Cthulhu.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,9 @@ end
@test occursin("< opaque closure call > $s", String(take!(buf)))
end

# an empty MultiCallInfo has no effects to merge; `mapreduce` without `init` threw
@test Cthulhu.get_effects(Cthulhu.MultiCallInfo(Tuple{}, Any, Cthulhu.CallInfo[])) == Cthulhu.CC.EFFECTS_TOTAL

# tasks
ftask() = @sync @async show(io, "Hello")
let callsites = find_callsites_by_ftt(ftask, Tuple{})
Expand Down
Loading