Skip to content

Give get_effects(::MultiCallInfo) an identity for empty callinfos - #708

Open
jishnub wants to merge 1 commit into
JuliaDebug:masterfrom
jishnub:fix-multicallinfo-effects
Open

jishnub wants to merge 1 commit into
JuliaDebug:masterfrom
jishnub:fix-multicallinfo-effects

Conversation

@jishnub

@jishnub jishnub commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

get_effects(mci::MultiCallInfo) is mapreduce(get_effects, merge_effects, mci.callinfos) with no init, so an empty MultiCallInfo throws instead of yielding effects. select_callsite already anticipates the empty case with its own error branch, but any effects display reaches get_effects before that.

EFFECTS_TOTAL is the identity of merge_effects (checked: merge_effects(EFFECTS_TOTAL, x) == x == merge_effects(x, EFFECTS_TOTAL) for EFFECTS_UNKNOWN and a partially-tainted Effects), so it is the right init.

Test: an empty MultiCallInfo now returns EFFECTS_TOTAL.

🤖 Generated with Claude Code

https://claude.ai/code/session_01NiXhCrQf5AJ2DmTmZ3FsSP

`mapreduce(get_effects, merge_effects, callinfos)` has no `init`, so an
empty `MultiCallInfo` threw instead of yielding effects. `select_callsite`
already guards the empty case, but any effects display reaches
`get_effects` first. `EFFECTS_TOTAL` is the identity of `merge_effects`.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NiXhCrQf5AJ2DmTmZ3FsSP
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (2c33b9a) to head (96c4b2a).
⚠️ Report is 101 commits behind head on master.

Files with missing lines Patch % Lines
src/compiler/callsite.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #708    +/-   ##
=======================================
  Coverage    0.00%   0.00%            
=======================================
  Files           9      22    +13     
  Lines        1556    1808   +252     
=======================================
- Misses       1556    1808   +252     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants