Repository navigation
Make streaming cursors subtype DBInterface.Cursor - #36
Merged
Merged
Conversation
Postgres.cursor returns a Postgres.Cursor, which did not subtype DBInterface.Cursor, so code that dispatches on the abstract cursor type (such as StructUtils' DBInterface extension, which writes a cursor as an array of rows) did not apply to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
quinnj
referenced
this pull request
Oct 30, 2026
Co-authored-by: Jacob Quinn <quinn.jacobd@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Postgres.Cursor(whatPostgres.cursorreturns) now subtypesDBInterface.Cursor.Why
Code that dispatches on the abstract cursor type skipped streaming Postgres cursors. The motivating case is JuliaServices/StructUtils.jl#95, which reads and writes any
DBInterface.Cursoras an array of its rows. With both changes, query results stream straight into JSON:Today
JSON.jsonon a cursor writes the cursor's fields, starting with its wholeConnection.Postgres.Result(fromDBInterface.execute) is anAbstractVectorof rows and already writes as an array of row objects, so it is unaffected.DBInterfacedefines no methods onDBInterface.Cursorthat change this package's behavior.Verification
cur isa DBInterface.Cursor.POSTGRES_REQUIRE_INTEGRATION=true,postgres:16) on Julia 1.12.6: 9242/9242.🤖 Generated with Claude Code