Repository navigation
Pin one Python version for dev, CI, and release - #77
Merged
Merged
Conversation
The patch version decides the bundled Tk: uv-managed 3.14.2 ships Tk 8.6 while 3.14.7 ships Tk 9.0 (what the packaged app uses). Because uv python install 3.14 happily linked an already-present 3.14.2, local dev ran Tk 8.6 and hid a Tk-9-only wheel bug. Pin .python-version to the exact patch and make CI and the release build install the interpreter from it via bare 'uv python install', so all three environments share one Python and one Tk. Document the parity requirement in AGENTS.md.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Local development ran a different Tk than the shipped app, which hid a Tk-9-only bug (covered by #76):
python3.13)Worse, even pinning the minor version wasn't enough: uv-managed 3.14.2 ships Tk 8.6 while 3.14.7 ships Tk 9.0, and
uv python install 3.14silently linked the already-present 3.14.2 on the dev machine. So "same minor version" can still mean a different Tk.Fix
.python-versionnow pins the exact patch (3.14.7), which is what ships and what CI installs.setupaction, release workflow) and the Linux build install the interpreter from.python-versionvia bareuv python install, so there is one source of truth for dev, CI, and release.AGENTS.mdgains a Development Environment Parity section: use the uv-managed interpreter, and checktkinter.TkVersionreports9.0before debugging input issues.Testing
python 3.14.7 | Tk 9.0.