Remove odometry data from mobile robot state#64
Merged
shantanuparab-tr merged 1 commit intoFeb 20, 2026
Conversation
shantanuparab-tr
requested review from
abhichothani42,
Copilot and
lukeschmitt-tr
February 13, 2026 19:52
There was a problem hiding this comment.
Pull request overview
This PR updates the Trossen AI Mobile robot’s state representation to remove absolute odometry (x, y, theta) and keep only velocity-based base state, aligning mobile platform datasets around a consistent base signal.
Changes:
- Removed
odom_x,odom_y,odom_thetafrommotor_features()["observation.state"].names. - Removed odometry fields from
get_base_state()so it returns onlylinear_velandangular_vel.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
3 tasks
|
@shantanuparab-tr I've opened a new pull request, #67, to work on those changes. Once the pull request is ready, I'll request review from you. |
lukeschmitt-tr
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed odometry position data (
x,y,theta) from the Trossen AI Mobile robot state representation, retaining only velocity-based information.Changes
"odom_x","odom_y", and"odom_theta"fromstate_namesin themotor_featurespropertyread_basemethod"linear_vel"and"angular_vel"in addition to arm motor namesMotivation
This change was made to:
Validation
The change was validated by:
This confirms that the action space remains consistent with the observation space and that removing absolute odometry values does not alter functional behavior.