Skip to content

fix(agent-vault): point personal value messages at Services, not an access bundle - #504

Open
scott-ray-wilson wants to merge 1 commit into
mainfrom
AGE2-372
Open

scott-ray-wilson wants to merge 1 commit into
mainfrom
AGE2-372

Conversation

@scott-ray-wilson

Copy link
Copy Markdown
Contributor

Description 📣

Pairs with the Infisical PR for AGE2-372: Infisical/infisical#9483. That PR lets a session name a project's services one by one, outside any access bundle.

Resolve sends a service named that way with accessBundleName null. Three proxy messages told a member to fix a personal value "on access bundle %q", so for such a service they pointed at access bundle "":

  • The refusal when the session owner hasn't set up their personal values for the service (errPersonalValuesMissing)
  • The 401 body when the upstream rejects a member's stored credential (staticCredentialRejectedBody)
  • The 401 body when a member's OAuth connection needs reconnecting (reauthorizationNeededBody)

Personal values are set per service, so each message now sends the member to the service under Services in Infisical Agent Vault. That holds whether the service came from an access bundle or was named on its own. The messages for credentials an admin stores are unchanged, and accessBundleName is still parsed from resolve, since session logs and hooks use it.

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests 🛠️

  • gofmt, go build ./..., go vet ./packages/agentvault/... and go test ./packages/agentvault/... pass. TestPersonalValuesMissing and TestAMemberProvidedRejectionTellsTheMemberWhatToFix now expect the new wording.
  • Through a real proxy against a local Infisical running the AGE2-372 branch, with a session that names a service whose personal value the session owner hadn't set:
# This branch
{"error":"policy_blocked","message":"service \"pr2-personal\" needs your own credential or sign-in, which isn't set up yet: blocked by service policy. Set it up under Services in Infisical Agent Vault, or for a machine identity, start the session on behalf of a user who has set it up. It can take a few minutes to apply.", ...}

# main
{"error":"policy_blocked","message":"service \"pr2-personal\" needs your own credential or sign-in, which isn't set up yet: blocked by service policy. Set it up on access bundle \"\" in Infisical Agent Vault, or for a machine identity, start the session on behalf of a user who has set it up. It can take a few minutes to apply.", ...}

After the owner saved the personal value, the same request went through with the credential attached. The two 401 bodies are covered by the unit tests above.


  • New or changed commands follow CLI.md, and new commands and flags are recorded in packages/cmd/testdata/command_surface.json
  • Updated AGENTS.md files (if needed)
  • I have read the contributing guide, agreed and acknowledged the code of conduct. 📝

🤖 Generated with Claude Code

…ccess bundle

A session can now name a project's services one by one, outside any
access bundle (the Infisical PR for AGE2-372). Resolve sends such a
service with accessBundleName null, so the three messages that told a
member to fix a personal value "on access bundle %q" read
`on access bundle ""`.

Personal values are set per service, so the messages now send the
member to the service under Services in Infisical Agent Vault:

- the proxy's refusal when the owner's personal values are missing
- the 401 body when the upstream rejects a member's stored credential
- the 401 body when a member's OAuth connection needs reconnecting

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@infisical-review-police

Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-cli-504-fix-agent-vault-point-personal-value-messages-at-services-not

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

@linear

linear Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

AGE2-372

AGE2-375

@veria-ai

veria-ai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

PR overview

No security issues were found in this pull request.

Reviews

@greptile-apps

greptile-apps Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5 Tier: plus

[Low impact] The PR appears safe to merge.

Summary

Updates three personal-value messages to direct members to Services in Infisical Agent Vault instead of an access bundle.

  • Agent Vault personal-value messages now point to Services.

No actionable issues found. Tests were not run during this review.

Reviews (2) · Last reviewed commit: "fix(agent-vault): point personal value m..." · Reviewed by Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant