Repository navigation
fix(agent-vault): point personal value messages at Services, not an access bundle - #504
Open
scott-ray-wilson wants to merge 1 commit into
Open
scott-ray-wilson wants to merge 1 commit into
scott-ray-wilson wants to merge 1 commit into
Conversation
…ccess bundle A session can now name a project's services one by one, outside any access bundle (the Infisical PR for AGE2-372). Resolve sends such a service with accessBundleName null, so the three messages that told a member to fix a personal value "on access bundle %q" read `on access bundle ""`. Personal values are set per service, so the messages now send the member to the service under Services in Infisical Agent Vault: - the proxy's refusal when the owner's personal values are missing - the 401 body when the upstream rejects a member's stored credential - the 401 body when a member's OAuth connection needs reconnecting Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
💬 Discussion in Slack: #pr-review-cli-504-fix-agent-vault-point-personal-value-messages-at-services-not Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
Open
6 of 11 tasks
Contributor
PR overviewNo security issues were found in this pull request. Reviews
|
Contributor
[Low impact] The PR appears safe to merge.
|
This was referenced Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📣
Pairs with the Infisical PR for AGE2-372: Infisical/infisical#9483. That PR lets a session name a project's services one by one, outside any access bundle.
Resolve sends a service named that way with
accessBundleNamenull. Three proxy messages told a member to fix a personal value "on access bundle %q", so for such a service they pointed ataccess bundle "":errPersonalValuesMissing)staticCredentialRejectedBody)reauthorizationNeededBody)Personal values are set per service, so each message now sends the member to the service under Services in Infisical Agent Vault. That holds whether the service came from an access bundle or was named on its own. The messages for credentials an admin stores are unchanged, and
accessBundleNameis still parsed from resolve, since session logs and hooks use it.Type ✨
Tests 🛠️
gofmt,go build ./...,go vet ./packages/agentvault/...andgo test ./packages/agentvault/...pass.TestPersonalValuesMissingandTestAMemberProvidedRejectionTellsTheMemberWhatToFixnow expect the new wording.After the owner saved the personal value, the same request went through with the credential attached. The two 401 bodies are covered by the unit tests above.
packages/cmd/testdata/command_surface.json🤖 Generated with Claude Code