Repository navigation
docs(agent-vault): say a session's skills come from more than its access bundle - #505
Open
scott-ray-wilson wants to merge 1 commit into
Open
scott-ray-wilson wants to merge 1 commit into
scott-ray-wilson wants to merge 1 commit into
Conversation
…ess bundle A session can now name project skills and carry skills sent with it, beside its access bundle's (the Infisical PR for AGE2-373). The skills fetch already installs whatever Infisical returns, so only the text changes: - `agent-vault run --help` described the skills as the ones in the session's access bundle - the comments on the 64 MB read limits for the skills response now give the bounds Infisical enforces: 25 skills through the access bundle, 20 named, and the inline skills in one 2 MB request Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
💬 Discussion in Slack: #pr-review-cli-505-docs-agent-vault-say-a-session-s-skills-come-from-more-than-it Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
6 of 11 tasks
Contributor
PR overviewNo security issues were found in this pull request. Reviews
|
Contributor
[Low impact] This text-only PR appears safe to merge.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📣
Pairs with Infisical/infisical#9486 (AGE2-373), which stacks on Infisical/infisical#9483. That PR lets session creation name project skills one by one and send skills that last only as long as the session, beside the access bundle's skills.
GET /api/v1/agent-vault/session/skillsalready returns every skill a session gets, and the CLI installs whatever it returns: the response shape is unchanged, each skill still has anid,versionandsha256, and the CLI checks the hash and keys its folders by name. So nothing the CLI does changes. Two places still described skills as coming from the access bundle:infisical agent-vault run --helpsaid the skills installed are "the skills in the session's access bundle". It now says the session's skills: its access bundle's, the ones it names and the ones sent with itsessionForwardMaxByteson the proxy,agentVaultSessionSkillsResponseLimitin the API client) said a bundle holds at most 25 skills, or that nothing bounds a session's skills. They now give the bounds Infisical enforces, which keep the worst case under 64 MB: 25 skills through the access bundle, 20 named, and the inline skills in one 2 MB requestStacked on #504 (AGE2-372).
Type ✨
Tests 🛠️
With this build as both the proxy and
agent-vault run, against an Infisical API running the AGE2-373 backend:infisical-agent-vaultpackages/cmd/testdata/command_surface.json🤖 Generated with Claude Code