Skip to content

Paint a framed Card's backdrop inside its content panel - #121

Merged
andrewhuhh merged 4 commits into
mainfrom
andrew/card-framed-backdrop
Nov 17, 2026
Merged

andrewhuhh merged 4 commits into
mainfrom
andrew/card-framed-backdrop

Conversation

@andrewhuhh

@andrewhuhh andrewhuhh commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

A framed Card painted its backdrop on the frame's chrome unless it had a frame footer. Without one, the Halftone sized itself to the whole card, so it covered the title band and the rim, and the opaque content panel hid it. #119 fixed this for StatCard only. This PR fixes it in Card, following Andrew's rule that the halftone lives in the content corners and the frame is chrome.

Change

A framed Card's backdrop now goes in a content panel in every case:

  • Frame footer: the inset, as before.
  • Convenience props without a frame footer (title, action, an inset footer): the CardContent that Card renders.
  • Composed from parts: the first CardContent child. If there's no CardContent, it stays on the card as before.

Plain cards, and framed cards nested in a frame (which drop to plain), don't change. On a linked card, a panel that holds a backdrop sits above the link overlay and passes clicks through to it, so controls in the body stay clickable while the rest of the card still follows the link.

Card now handles StatCard's case, so StatCard goes back to passing backdrop straight through. The stat-card-linked baselines from #119 stay byte-identical.

Blast radius

  • Showcase: no existing example draws a framed Card with a backdrop and no frame footer, so no existing baseline changes. The new example "Framed, without a frame footer" on the Halftone page covers all three paths (title in the band, inset footer, and composed from parts), plus a linked card with a button in its body. The renders below were taken before that fourth card was added.
  • v4: the only v4 Cards with a backdrop are on ProjectsPage and ProjectTypePage, and both use footerPlacement="frame", so neither changes. The 0.1.14 RC check confirms this against v4 and license-server-go.

Visual gate

All 410 tests pass, and the only new baselines are the four halftone-framed images (hence visual-change). Below, before is the current behaviour rendered from main and after is this change: on desktop, before is on top; at 390px, before is on the left.

Desktop, Light
Desktop, Dark
390px, Light 390px, Dark

At 390px, a one-line body puts the wash behind the body text. That's expected now that the wash lives in the content panel, and it's for design review.

Open in Capy

andrewhuhh and others added 2 commits November 17, 2026 20:36
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
@infisical-review-police

Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-cipher-121-paint-a-framed-card-s-backdrop-inside-its-content-panel

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

@greptile-apps

greptile-apps Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5 Tier: plus

[Medium impact] The PR appears safe to merge, with no new actionable issues found.

Summary

Framed Card backdrops now sit inside the content panel. StatCard passes its backdrop through to Card.

  • Framed Cards place their backdrop in the content area.

Reviews (3) · Last reviewed commit: "Keep the link cover on the card and leav..." · Reviewed by Greptile

Comment thread src/ui/card.tsx Resolved
Comment thread src/ui/card.tsx Resolved
Comment thread src/ui/card.tsx Resolved
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Comment thread src/ui/row-link.module.css Resolved
Comment thread src/ui/card.tsx Resolved
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
@andrewhuhh
andrewhuhh merged commit ee1c1b8 into main Nov 17, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant