Repository navigation
Paint a framed Card's backdrop inside its content panel - #121
Merged
Merged
Conversation
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
💬 Discussion in Slack: #pr-review-cipher-121-paint-a-framed-card-s-backdrop-inside-its-content-panel Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
[Medium impact] The PR appears safe to merge, with no new actionable issues found.
|
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This was referenced Nov 17, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A framed Card painted its
backdropon the frame's chrome unless it had a frame footer. Without one, the Halftone sized itself to the whole card, so it covered the title band and the rim, and the opaque content panel hid it. #119 fixed this for StatCard only. This PR fixes it in Card, following Andrew's rule that the halftone lives in the content corners and the frame is chrome.Change
A framed Card's backdrop now goes in a content panel in every case:
title,action, an insetfooter): the CardContent that Card renders.CardContentchild. If there's no CardContent, it stays on the card as before.Plain cards, and framed cards nested in a frame (which drop to plain), don't change. On a linked card, a panel that holds a backdrop sits above the link overlay and passes clicks through to it, so controls in the body stay clickable while the rest of the card still follows the link.
Card now handles StatCard's case, so StatCard goes back to passing
backdropstraight through. Thestat-card-linkedbaselines from #119 stay byte-identical.Blast radius
footerPlacement="frame", so neither changes. The 0.1.14 RC check confirms this against v4 and license-server-go.Visual gate
All 410 tests pass, and the only new baselines are the four
halftone-framedimages (hencevisual-change). Below, before is the current behaviour rendered from main and after is this change: on desktop, before is on top; at 390px, before is on the left.At 390px, a one-line body puts the wash behind the body text. That's expected now that the wash lives in the content panel, and it's for design review.