Skip to content

Support already merged PRs in the release candidate check - #125

Open
andrewhuhh wants to merge 2 commits into
mainfrom
andrew/visual-rc-merge-commits
Open

andrewhuhh wants to merge 2 commits into
mainfrom
andrew/visual-rc-merge-commits

Conversation

@andrewhuhh

@andrewhuhh andrewhuhh commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Lets the release candidate check run after its PRs have already merged, and fixes a spec filter that made nested step worktrees render nothing.

--merged

The check used to start the candidate at main and merge each PR's head. That fails once the PRs have merged, because a squash-merged PR's head isn't on main ("PR #118 conflicts with the candidate outside r/"). With --merged:

  • each PR is given as N=<sha of its commit on main>, in merge order
  • the candidate starts at the base tag and applies each commit in turn, and the separate main step is skipped
  • a PR's baseline updates, merge edits and stylesheet changes are read from <sha>^1..<sha> instead of origin/main...<head>, so squash and merge commits both work

The default mode is unchanged.

Nested worktrees and empty steps

Each step renders inside a worktree nested under visual/rc/. Playwright also collected the nested copies of the specs, loaded a second @playwright/test ("Requiring @playwright/test second time") and rendered 0 snapshots, and || true hid it. playwright.config.ts now ignores **/visual/rc/**, and a step that renders no snapshots fails the check.

render() also restores the three preview files it copies into the candidate, so a later PR that edits one of them still merges.

Verification

I ran --merged --base v0.1.13 --version 0.1.14 with 118=f4de878 119=491308f 120=5e843d9 121=ee1c1b8, the four 0.1.14 PRs, two of them squash-merged.

  • Every step rendered (1410 to 1418 snapshots).

  • The 8 stat-card-linked and halftone-framed additions were attributed to Contain the link overlay in a linked StatCard #118 and Paint a framed Card's backdrop inside its content panel #121 from their commits on main.

  • The run still reported 21 unexplained entries, and every one is render flake rather than a real change:

    • table snapshots that drop out at one step and come back at the next
    • progress-default animation noise
    • one terminal-stress frame

    The same flakes appeared in local runs on a loaded machine. The earlier 0.1.14 RC run passed cleanly with the same two fixes applied by hand.

Updated the README with a --merged example.

Open in Capy

After the review fixes, a run limited to the badge and stat-card pages rendered every step (28 to 32 snapshots, including stat-card-link.spec.ts) and explained every change.

… its spec filter

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
@capy-ai capy-ai Bot added the live-preview label Nov 18, 2026
@infisical-review-police

Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-cipher-125-support-already-merged-prs-in-the-release-candidate-check

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5 Tier: plus

[Low impact] The PR appears safe to merge.

Summary

The release candidate check can replay already-merged PRs from the previous release tag and read each PR’s changes from its commit on main.

  • Release checks can replay PR commits after they have merged.
  • Visual release checks use the checkout’s spec and require snapshots.

Both earlier findings are addressed. No new actionable issues were found.

Reviews (2) · Last reviewed commit: "Ignore nested release worktrees in the t..." · Reviewed by Greptile

Comment thread scripts/visual-rc.sh Resolved
Comment thread scripts/visual-rc.sh Resolved
…iles after each step, and fail a step that renders nothing

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant