Repository navigation
Support already merged PRs in the release candidate check - #125
Open
andrewhuhh wants to merge 2 commits into
Open
andrewhuhh wants to merge 2 commits into
andrewhuhh wants to merge 2 commits into
Conversation
… its spec filter Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
💬 Discussion in Slack: #pr-review-cipher-125-support-already-merged-prs-in-the-release-candidate-check Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
[Low impact] The PR appears safe to merge.
|
…iles after each step, and fail a step that renders nothing Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets the release candidate check run after its PRs have already merged, and fixes a spec filter that made nested step worktrees render nothing.
--mergedThe check used to start the candidate at main and merge each PR's head. That fails once the PRs have merged, because a squash-merged PR's head isn't on main ("PR #118 conflicts with the candidate outside r/"). With
--merged:N=<sha of its commit on main>, in merge order<sha>^1..<sha>instead oforigin/main...<head>, so squash and merge commits both workThe default mode is unchanged.
Nested worktrees and empty steps
Each step renders inside a worktree nested under
visual/rc/. Playwright also collected the nested copies of the specs, loaded a second@playwright/test("Requiring @playwright/test second time") and rendered 0 snapshots, and|| truehid it.playwright.config.tsnow ignores**/visual/rc/**, and a step that renders no snapshots fails the check.render()also restores the three preview files it copies into the candidate, so a later PR that edits one of them still merges.Verification
I ran
--merged --base v0.1.13 --version 0.1.14with118=f4de878 119=491308f 120=5e843d9 121=ee1c1b8, the four 0.1.14 PRs, two of them squash-merged.Every step rendered (1410 to 1418 snapshots).
The 8
stat-card-linkedandhalftone-framedadditions were attributed to Contain the link overlay in a linked StatCard #118 and Paint a framed Card's backdrop inside its content panel #121 from their commits on main.The run still reported 21 unexplained entries, and every one is render flake rather than a real change:
progress-defaultanimation noiseterminal-stressframeThe same flakes appeared in local runs on a loaded machine. The earlier 0.1.14 RC run passed cleanly with the same two fixes applied by hand.
Updated the README with a
--mergedexample.After the review fixes, a run limited to the badge and stat-card pages rendered every step (28 to 32 snapshots, including
stat-card-link.spec.ts) and explained every change.