Skip to content

Paint a framed StatCard's backdrop inside its content panel - #119

Merged
andrewhuhh merged 2 commits into
mainfrom
andrew/stat-card-framed-backdrop
Nov 17, 2026
Merged

andrewhuhh merged 2 commits into
mainfrom
andrew/stat-card-framed-backdrop

Conversation

@andrewhuhh

Copy link
Copy Markdown
Collaborator

A framed StatCard painted its backdrop on the outer frame instead of in its content panel. StatCard passed backdrop to Card, and Card puts a backdrop inside the inset only when a framed card has a frame footer. Otherwise it goes on the card itself. A framed StatCard has no footer, so the Halftone sized itself to the whole frame. The opaque content panel then covered it, and only the tinted 3px frame rim showed dots. This was a fallthrough, not a deliberate choice.

Fix

A framed StatCard now renders backdrop as the first child of its content panel, so the Halftone sizes itself to that panel and is clipped to it. It never reaches the frame rim. A plain StatCard, or one inside another frame (which drops to plain), still hands backdrop to Card as before.

The link overlay still belongs to the card, so the whole card stays clickable, and the stat-card-link spec still passes. Hover behaviour is unchanged and stays with R6/R7.

Visual gate

All 410 tests pass. The four stat-card-linked baselines change, and only in the framed card with a Halftone (Total licenses). The Dark change falls under the per-pixel threshold, so the gate wouldn't have flagged it. I updated those baselines anyway so they match what renders. No other baseline changes.

Before is on top and after is below (desktop crop). At 390px, before is on the left and after is on the right.

Light Dark
390px, Light 390px, Dark

Open in Capy

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
@infisical-review-police

Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-cipher-119-paint-a-framed-statcard-s-backdrop-inside-its-content-panel

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

@greptile-apps

greptile-apps Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5 Tier: plus

[Low impact] The PR appears safe to merge.

Summary

Moves a framed StatCard’s backdrop into its content panel instead of painting it on the outer frame.

  • Framed StatCards show backdrops inside their content panels.

Reviews (2) · Last reviewed commit: "Call useInFrame unconditionally in StatC..." · Reviewed by Greptile

Comment thread src/ui/stat-card.tsx Resolved
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
@andrewhuhh
andrewhuhh merged commit 491308f into main Nov 17, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant