Repository navigation
Paint a framed StatCard's backdrop inside its content panel - #119
Merged
Merged
Conversation
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
💬 Discussion in Slack: #pr-review-cipher-119-paint-a-framed-statcard-s-backdrop-inside-its-content-panel Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
[Low impact] The PR appears safe to merge.
|
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This was referenced Nov 17, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A framed StatCard painted its
backdropon the outer frame instead of in its content panel. StatCard passedbackdropto Card, and Card puts a backdrop inside the inset only when a framed card has a frame footer. Otherwise it goes on the card itself. A framed StatCard has no footer, so the Halftone sized itself to the whole frame. The opaque content panel then covered it, and only the tinted 3px frame rim showed dots. This was a fallthrough, not a deliberate choice.Fix
A framed StatCard now renders
backdropas the first child of its content panel, so the Halftone sizes itself to that panel and is clipped to it. It never reaches the frame rim. A plain StatCard, or one inside another frame (which drops to plain), still handsbackdropto Card as before.The link overlay still belongs to the card, so the whole card stays clickable, and the
stat-card-linkspec still passes. Hover behaviour is unchanged and stays with R6/R7.Visual gate
All 410 tests pass. The four
stat-card-linkedbaselines change, and only in the framed card with a Halftone (Total licenses). The Dark change falls under the per-pixel threshold, so the gate wouldn't have flagged it. I updated those baselines anyway so they match what renders. No other baseline changes.Before is on top and after is below (desktop crop). At 390px, before is on the left and after is on the right.