Repository navigation
Contain the link overlay in a linked StatCard - #118
Merged
Merged
Conversation
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
💬 Discussion in Slack: #pr-review-cipher-118-contain-the-link-overlay-in-a-linked-statcard Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
[Low impact] The PR appears safe to merge.
|
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This was referenced Nov 17, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A linked StatCard didn't contain its link overlay. StatCard sets
data-slot="stat-card"over Card's"card", so row-link's[data-slot="card"][data-stretched-link] { position: relative }never matched it. The CardLink overlay stretched to the nearest positioned ancestor, often the page, and a click anywhere went to the last linked tile's target. This affects framed and plain cards, with or without a backdrop, on v0.1.12 and v0.1.13.Fix
row-link.module.css now matches
[data-slot="stat-card"][data-stretched-link]in its two structural rules:position: relativeandcursor: pointer.I chose matching the slot over making StatCard keep
data-slot="card"with a separate marker. Keeping Card's slot would also pull StatCard into every hover selector keyed to"card"(the Halftone wash, icon draw motion, and the linked-card hover tint). That's the R7 hover change, which needs its own design call. It would also break any consumer that queries[data-slot="stat-card"].Audit of
[data-slot="card"]selectors[data-stretched-link]position and cursor:where(...)control lift[data-stretched-link]:hovertintdata-icon-motion="draw"on hoverclosest('[data-slot="card"]')Showcase and test
The new example "Linked, framed and plain" puts four linked StatCards in a Grid: framed and plain, each with and without a Halftone backdrop. The first card's note is its own link.
visual/stat-card-link.spec.tsclicks below the grid and on the section heading and checks the URL doesn't change. It then clicks each card's value and checks that card's destination, and clicks the note link and checks it goes to its own target, not the card's. Without the CSS fix, the outside clicks navigate and the spec fails.Visual gate
All 410 tests pass and no existing baseline changes. The only baselines are the four new
stat-card-linkedimages, which is why this PR hasvisual-change.