Skip to content

Tile and TilePickerItem link form - #110

Open
andrewhuhh wants to merge 3 commits into
mainfrom
andrew/tile-link
Open

andrewhuhh wants to merge 3 commits into
mainfrom
andrew/tile-link

Conversation

@andrewhuhh

@andrewhuhh andrewhuhh commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Closes the first INF-177 gap: Tile and TilePickerItem can be real links, so hover shows the URL and cmd-click, ctrl-click and middle-click open it elsewhere.

Tile

  • href renders an <a> instead of a <button>. Plain clicks are left alone, so the browser handles modifier and middle clicks.
  • external adds target="_blank" and rel="noopener noreferrer", and marks the tile with the external icon (labelled "Opens in a new tab"). In the row layout it replaces the chevron; in the stacked layout it sits beside the eyebrow and never shrinks.
  • asChild renders the one child, such as a router Link, with the tile's content inside it. Set the child's target yourself when it is external.
  • With disabledReason, a link tile drops its href (no URL on hover, no navigation) and stays focusable with role="link" and aria-disabled.
  • disabled on a link tile also drops its destination and dims it. With asChild, an inactive tile strips the child's href too, so middle-click and Open in new tab can't reach it.
  • Link tiles use aria-current="page" for selected instead of aria-pressed, with the same selected border.
  • Props are a union: the button form takes button props, the link form takes anchor props (target, download, an anchor onClick) and an anchor ref.

TilePicker

  • TilePickerItem gains href and external. An item with an href navigates instead of calling onSelect, which is now optional for pickers made only of links.

New examples: item/tile-links and tile-picker/links (Agent Vault style, with Custom HTTP and MCP as external links).

Checked in the browser: every link tile is an <a> with its href, external ones carry target, rel and the marker, a cmd-click is not prevented, and a click on a disabled link is.

Light Dark
Optimal: row and stacked link tiles, external hovered tiles light tiles dark
TilePicker with link items, external hovered picker light picker dark
Stressed: long titles and eyebrows, disabled links (reason, asChild, disabled), a selected link stressed light stressed dark

Open in Capy

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
@infisical-review-police

Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-cipher-110-tile-and-tilepickeritem-link-form

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

@capy-ai capy-ai Bot added the live-preview label Nov 17, 2026
@capy-ai capy-ai Bot mentioned this pull request Nov 17, 2026
@greptile-apps

greptile-apps Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5 Tier: plus

[Medium impact] The PR appears safe to merge; no new actionable issues were found.

Summary

Adds real links to Tile and TilePickerItem, including external-link markers, disabled states, and catalog examples.

  • Tiles now open destinations like normal links.
  • Picker choices can navigate without a selection callback.

Reviews (3) · Last reviewed commit: "Tile: asChild keeps the child's href, di..." · Reviewed by Greptile

Comment thread src/ui/item.tsx Resolved
Comment thread src/ui/item.tsx Resolved
Comment thread src/ui/item.tsx Resolved
Comment thread src/ui/item.tsx Resolved
…link props typed as an anchor

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Comment thread src/ui/item.tsx Resolved
Comment thread src/ui/helpers.module.css Resolved
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant