Repository navigation
Tile and TilePickerItem link form - #110
Open
andrewhuhh wants to merge 3 commits into
Open
andrewhuhh wants to merge 3 commits into
andrewhuhh wants to merge 3 commits into
Conversation
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
💬 Discussion in Slack: #pr-review-cipher-110-tile-and-tilepickeritem-link-form Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
[Medium impact] The PR appears safe to merge; no new actionable issues were found.
|
…link props typed as an anchor Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the first INF-177 gap: Tile and TilePickerItem can be real links, so hover shows the URL and cmd-click, ctrl-click and middle-click open it elsewhere.
Tile
hrefrenders an<a>instead of a<button>. Plain clicks are left alone, so the browser handles modifier and middle clicks.externaladdstarget="_blank"andrel="noopener noreferrer", and marks the tile with theexternalicon (labelled "Opens in a new tab"). In the row layout it replaces the chevron; in the stacked layout it sits beside the eyebrow and never shrinks.asChildrenders the one child, such as a router Link, with the tile's content inside it. Set the child'stargetyourself when it is external.disabledReason, a link tile drops itshref(no URL on hover, no navigation) and stays focusable withrole="link"andaria-disabled.disabledon a link tile also drops its destination and dims it. WithasChild, an inactive tile strips the child'shreftoo, so middle-click and Open in new tab can't reach it.aria-current="page"forselectedinstead ofaria-pressed, with the same selected border.target,download, an anchoronClick) and an anchor ref.TilePicker
TilePickerItemgainshrefandexternal. An item with anhrefnavigates instead of callingonSelect, which is now optional for pickers made only of links.New examples: item/tile-links and tile-picker/links (Agent Vault style, with Custom HTTP and MCP as external links).
Checked in the browser: every link tile is an
<a>with itshref, external ones carrytarget,reland the marker, a cmd-click is not prevented, and a click on a disabled link is.disabled), a selected link