Repository navigation
TilePicker pinned items - #111
Open
andrewhuhh wants to merge 1 commit into
Open
andrewhuhh wants to merge 1 commit into
andrewhuhh wants to merge 1 commit into
Conversation
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
💬 Discussion in Slack: #pr-review-cipher-111-tilepicker-pinned-items Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
[Medium impact] This PR appears safe to merge; pinned choices remain available without changing empty-search behavior.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the second INF-177 gap: TilePicker items can be pinned so they stay listed whatever the search, for catch-alls like Agent Vault's Custom HTTP and MCP.
TilePickerItem.pinned: a search lists its matches first, then every pinned item it didn't match, so pinned items never appear twice.New example: tile-picker/pinned.
git: GitHub and GitLab, then Custom HTTP and MCPsalesforce: no matches, pinned items still listedOverlaps: against #104 only the generated
r/tile-picker.jsonconflicts. Against #110 the item type, the catalog entry and that generated file conflict, since both add to the same spots. Whichever of #110 and #111 merges second needs main merged in, and I'll do that.