Skip to content

spirv-tools: build static library as well #281067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crueter wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

spirv-tools: build static library as well #281067

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Formula/s/spirv-tools.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"-DPython3_EXECUTABLE=#{which("python3")}",
"-DSPIRV-Headers_SOURCE_DIR=#{Formula["spirv-headers"].opt_prefix}",
"-DSPIRV_SKIP_TESTS=ON",
"-DSPIRV_TOOLS_BUILD_STATIC=OFF",
"-DSPIRV_TOOLS_BUILD_STATIC=ON",
*std_cmake_args
system "cmake", "--build", "build"
system "cmake", "--install", "build"
Expand All @@ -44,7 +44,7 @@
(libexec/"examples").install "examples/cpp-interface/main.cpp"
end

test do

Check failure on line 47 in Formula/s/spirv-tools.rb

View workflow job for this annotation

GitHub Actions / Linux arm64

`brew test --verbose spirv-tools` failed on Linux arm64! 

/usr/bin/ld: /home/linuxbrew/.linuxbrew/Cellar/spirv-tools/1.4.341.0/lib/libSPIRV-Tools-opt.a(pass_manager.cpp.o): in function `spvtools::utils::ScopedTimer<spvtools::utils::Timer>::~ScopedTimer()':
pass_manager.cpp:(.text._ZN8spvtools5utils11ScopedTimerINS0_5TimerEED0Ev[_ZN8spvtools5utils11ScopedTimerINS0_5TimerEED5Ev]+0x38): undefined reference to `spvtools::utils::Timer::Report(char const*)'
/usr/bin/ld: /home/linuxbrew/.linuxbrew/Cellar/spirv-tools/1.4.341.0/lib/libSPIRV-Tools-opt.a(vector_dce.cpp.o): in function `spvtools::opt::VectorDCE::AddItemToWorkListIfNeeded(spvtools::opt::VectorDCE::WorkListItem, std::unordered_map<unsigned int, spvtools::utils::BitVector, std::hash<unsigned int>, std::equal_to<unsigned int>, std::allocator<std::pair<unsigned int const, spvtools::utils::BitVector> > >*, std::vector<spvtools::opt::VectorDCE::WorkListItem, std::allocator<spvtools::opt::VectorDCE::WorkListItem> >*)':
vector_dce.cpp:(.text+0x1604): undefined reference to `spvtools::utils::BitVector::Or(spvtools::utils::BitVector const&)'
/usr/bin/ld: vector_dce.cpp:(.text+0x1694): undefined reference to `spvtools::utils::BitVector::Or(spvtools::utils::BitVector const&)'
collect2: error: ld returned 1 exit status
::error::spirv-tools: failed
An exception occurred within a child process:
  BuildError: Failed executing: /usr/bin/gcc-12 -o test test.cpp -std=c++11 -I/home/linuxbrew/.linuxbrew/Cellar/spirv-tools/1.4.341.0/include -L/home/linuxbrew/.linuxbrew/Cellar/spirv-tools/1.4.341.0/lib -lSPIRV-Tools -lSPIRV-Tools-link -lSPIRV-Tools-opt -lstdc++ -lm
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula.rb:3483:in 'block in Formula#system'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula.rb:3419:in 'IO.open'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula.rb:3419:in 'Formula#system'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.13164/lib/types/private/methods/call_validation.rb:286:in 'UnboundMethod#bind_call'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.13164/lib/types/private/methods/call_validation.rb:286:in 'T::Private::Methods::CallValidation.validate_call'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.13164/lib/types/private/methods/_methods.rb:259:in 'block in Formula#_on_method_added'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/s/spirv-tools.rb:50:in 'block in <class:SpirvTools>'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula.rb:3198:in 'block (3 levels) in Formula#run_test'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/extend/kernel.rb:233:in 'Kernel#with_env'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.13164/lib/types/private/methods/call_validation.rb:286:in 'UnboundMethod#bind_call'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.13164/lib/types/private/methods/call_validation.rb:286:in 'T::Private::Methods::CallValidation.validate_call'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.13164/lib/types/private/methods/_methods.rb:259:in 'block in Kernel#_on_method_added'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula.rb:3197:in 'block (2 levels) in Formula#run_test'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula.rb:1459:in 'Formula#with_logging'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.13164/lib/types/private/methods/call_validation.rb:286:in 'UnboundMethod#bind_call'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.13164/lib/types/private/methods/call_validation.rb:286:in 'T::Private::Methods::CallValidation.validate_call'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/4.0.0/gems/sorbet-runtime-0.6.13164/lib/types/private/methods/_methods.rb
cp libexec/"examples/main.cpp", "test.cpp"

args = if OS.mac?
Expand Down
Loading