spirv-tools: build static library as well#281067
Open
crueter wants to merge 1 commit intoHomebrew:mainfrom
Open
spirv-tools: build static library as well#281067crueter wants to merge 1 commit intoHomebrew:mainfrom
crueter wants to merge 1 commit intoHomebrew:mainfrom
Conversation
Not sure why this was off. It's particularly useful for certain CI applications where SPIRV-Tools is better off being linked statically
Contributor
|
I think as per brews policy, it is preferred to have shared libs. https://docs.brew.sh/Acceptable-Formulae#shared-vs-static-libraries. And if there are static libs required formulae might ship both. (ignore this if you actually meant to have shared AND static) |
Contributor
Author
|
Yeah I want to have shared and static. Their handling is kind of goofed up right now, which might cause the build failure; I do have a pending PR there to fix it KhronosGroup/SPIRV-Tools#6481 but it stalled because I'm lazy and also haven't called for reviews yet. Will investigate more when I next get access to my ARM linux machine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure why this was off. It's particularly useful for certain CI applications where SPIRV-Tools is better off being linked statically
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>?brew test <formula>?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?