ci: fetch dependencies before the fork PR offline budget measurement - #6434
Merged
Merged
Conversation
The fork-PR "macOS budget and eval" job runs on a cold runner with save-if: false caches, then measures the persistence backlog with --offline before anything fetched the registry. Run 35873406162 job 107223199141 failed with `no matching package named serde found`. Fetch with `cargo fetch --locked` first, the same pattern the Test job already uses. Jobs, permissions, fork guards and cache restrictions are unchanged. Evidence: 3 measurement-harness and 18 budget-harness tests passed locally. Cold fork-runner acceptance remains outstanding until a fork PR runs against this workflow. actionlint still reports 12 pre-existing ShellCheck findings that reproduce on the parent commit. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Hmbown
pushed a commit
to Lstarsky0/CodeWhale
that referenced
this pull request
Sep 23, 2026
diagnostics_list_and_read_bounded_windows compared the crash directory the API reports (built with Path::join) against a fixture path written as "cwhome/crashes", which only matches on Unix. Windows CI failed on unrelated PRs (Hmbown#6433 job 107246026498, Hmbown#6434 job 107246133133): left `...\cwhome\crashes`, right `...\cwhome/crashes`. The product is correct; the fixture now joins components. Evidence: the test passes locally (1 passed, 0 failed); Windows acceptance is the next hosted run. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fork-PR "macOS budget and eval" job runs on a cold runner with
save-if: false caches, then measures the persistence backlog with
--offline before anything fetched the registry. Run 35873406162 job
107223199141 failed with
no matching package named serde found.Fetch with
cargo fetch --lockedfirst, the same pattern the Test jobalready uses. Jobs, permissions, fork guards and cache restrictions are
unchanged.
Evidence: 3 measurement-harness and 18 budget-harness tests passed
locally. Cold fork-runner acceptance remains outstanding until a fork
PR runs against this workflow. actionlint still reports 12 pre-existing
ShellCheck findings that reproduce on the parent commit.
Refs #6417 (its fork-budget job fails for this reason; a new run is needed after this lands, since pull_request runs use the merge ref's workflow).
🤖 Generated with Claude Code