Skip to content

test(runtime-api): build expected diagnostics paths with Path::join - #6444

Open
Hmbown wants to merge 1 commit into
mainfrom
test/windows-diagnostics-paths
Open

Hmbown wants to merge 1 commit into
mainfrom
test/windows-diagnostics-paths

Conversation

@Hmbown

@Hmbown Hmbown commented Sep 23, 2026

Copy link
Copy Markdown
Owner

No-Issue: Windows CI fixture bug found on unrelated PRs.

diagnostics_list_and_read_bounded_windows compared the crash directory
the API reports (built with Path::join) against a fixture path written
as "cwhome/crashes", which only matches on Unix. Windows CI failed on
unrelated PRs (#6433 job 107246026498, #6434 job 107246133133):
left ...\cwhome\crashes, right ...\cwhome/crashes. The product is
correct; the fixture now joins components.

Evidence: the test passes locally (1 passed, 0 failed); Windows
acceptance is the next hosted run.

🤖 Generated with Claude Code

diagnostics_list_and_read_bounded_windows compared the crash directory
the API reports (built with Path::join) against a fixture path written
as "cwhome/crashes", which only matches on Unix. Windows CI failed on
unrelated PRs (#6433 job 107246026498, #6434 job 107246133133):
left `...\cwhome\crashes`, right `...\cwhome/crashes`. The product is
correct; the fixture now joins components.

Evidence: the test passes locally (1 passed, 0 failed); Windows
acceptance is the next hosted run.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings September 23, 2026 16:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants