Conversation
Refs #6418. A refused session switch always said the saved Runtime store "belongs to a different host", whatever the actual guard was. When another running Codewhale process holds the store, the suggested `codewhale resume` meets the same holder, so the advice was wrong. RuntimeStoreBinding::adoption_refusal returns the first guard that did not provably hold (unconfined, not a directory, held by a live process, durable work in a named directory, scope-pinned automation). It fails closed and never widens what is adoptable. The switch path now names the reason, and a live holder gets the step that actually frees the store. has_no_durable_work lost its last production consumer, so its two test assertions move to adoption_refusal and the helper is removed instead of suppressed. Mined from the unreviewed 0.10.1 WIP branch (runtime_threads.rs and its adoption_refusal test module); the UI consumer migration is new. Evidence: 17 passed, 0 failed (13,233 skipped) across runtime_store_binding, adoption_refusal and adoptable selections. TUI all-target/all-feature Clippy with CI flags and fmt passed; dead-code budget stays at 279. This is a diagnostic, not a fix for the #6418 reporter's store; that still needs their store/binding evidence. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #6418. A refused session switch always said the saved Runtime
store "belongs to a different host", whatever the actual guard was.
When another running Codewhale process holds the store, the suggested
codewhale resumemeets the same holder, so the advice was wrong.RuntimeStoreBinding::adoption_refusal returns the first guard that did
not provably hold (unconfined, not a directory, held by a live process,
durable work in a named directory, scope-pinned automation). It fails
closed and never widens what is adoptable. The switch path now names
the reason, and a live holder gets the step that actually frees the
store. has_no_durable_work lost its last production consumer, so its
two test assertions move to adoption_refusal and the helper is removed
instead of suppressed.
Mined from the unreviewed 0.10.1 WIP branch (runtime_threads.rs and its
adoption_refusal test module); the UI consumer migration is new.
Evidence: 17 passed, 0 failed (13,233 skipped) across
runtime_store_binding, adoption_refusal and adoptable selections. TUI
all-target/all-feature Clippy with CI flags and fmt passed; dead-code
budget stays at 279. This is a diagnostic, not a fix for the #6418
reporter's store; that still needs their store/binding evidence.
🤖 Generated with Claude Code