feat(web): move legal/terms and legal/privacy onto the dictionary spine (#5337) - #6417
Merged
Merged
Conversation
Contributor
|
Thanks @Lstarsky0 for taking the time to contribute. This repository is observing a maintainer-managed PR intake gate in dry-run mode, so this pull request is staying open. This note helps maintainers prepare the allowlist before any enforcement is considered. Please read |
…ne (Hmbown#5337) Copy moved verbatim; the binding English terms stay in lib/legal-copy. Rendered body, title and meta are unchanged across all 18 locales, and CEILING drops to the new count of 15. check-locales now covers both new dictionaries, plus docs-work.ts, which the docs/work migration left out. Signed-off-by: Lstarsky0 <59827030+Lstarsky0@users.noreply.github.com>
Lstarsky0
force-pushed
the
feat/legal-pages-dictionary-spine
branch
from
September 23, 2026 14:20
2f98caa to
30ebf3e
Compare
This was referenced Sep 23, 2026
Hmbown
approved these changes
Sep 24, 2026
timothybrush
pushed a commit
to timothybrush/DeepSeek-TUI
that referenced
this pull request
Sep 24, 2026
The RSS budget and offline eval ran inside Test for every trusted event, assuming the warm self-hosted Mac. With CW_SELF_HOSTED_MAC off, a trusted PR's macOS leg is a cold GitHub-hosted Mac, where Test alone took 77-80 minutes on 2026-09-23 (Hmbown#6431, Hmbown#6417) and the two extra steps would pass the 90-minute limit. Route both steps by runner, not trust: inside Test only on the self-hosted Mac, otherwise in the parallel macos-budget job. Raise Test's timeout to 120 minutes for cold hosted Macs. This makes the existing kill switch safe to use: the single self-hosted runner had 14 queued runs and dropped jobs with "lost communication". Verification: actionlint with CI's flags (-ignore SC2129/SC2221/SC2222) clean. No tests run; workflow-only change, CI is the proof. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
legal/termsandlegal/privacywere still forking their page chrome onisZh. The strings move tolegal-terms.ts/legal-privacy.tsbehindgetLegalTerms/getLegalPrivacy, held to the page-body contract next to thechangelog. Copy is verbatim.
The terms themselves stay where they are. They are English for every locale on
purpose, and the zh page says the English text is the binding one, so they are
not dictionary copy.
The effective-date line used to be two translated fragments around
{LEGAL_UPDATED}in the JSX. It is now onefill()template, and a new testkeeps
{date}in both locales so a translation can't quietly drop the date offa legal page.
CEILINGgoes to 15, the count the test now reports.check-locales.mjsnow lists both new files, plusdocs-work.ts, which thedocs/work migration left out.
No-Issue: two pages of the #5337 umbrella, which stays open.
Testing
Web only, no Rust touched. From
web/:npm test— 491 passednpm run check— cleannode scripts/check-locales.mjs— passes, and fails if zh drops a key or{date}Rendered output, main vs this branch, both pages in all 18 locales: body text
and
<title>/description/og:/twitter:meta identical. As a control, thesame comparison flags a single removed space after 于 in the zh date line, and
a one-character change to the zh description.
Checklist