Skip to content

feat(web): move legal/terms and legal/privacy onto the dictionary spine (#5337) - #6417

Merged
Hmbown merged 2 commits into
Hmbown:mainfrom
Lstarsky0:feat/legal-pages-dictionary-spine
Sep 24, 2026
Merged

Hmbown merged 2 commits into
Hmbown:mainfrom
Lstarsky0:feat/legal-pages-dictionary-spine

Conversation

@Lstarsky0

@Lstarsky0 Lstarsky0 commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Summary

legal/terms and legal/privacy were still forking their page chrome on
isZh. The strings move to legal-terms.ts / legal-privacy.ts behind
getLegalTerms / getLegalPrivacy, held to the page-body contract next to the
changelog. Copy is verbatim.

The terms themselves stay where they are. They are English for every locale on
purpose, and the zh page says the English text is the binding one, so they are
not dictionary copy.

The effective-date line used to be two translated fragments around
{LEGAL_UPDATED} in the JSX. It is now one fill() template, and a new test
keeps {date} in both locales so a translation can't quietly drop the date off
a legal page.

CEILING goes to 15, the count the test now reports.

check-locales.mjs now lists both new files, plus docs-work.ts, which the
docs/work migration left out.

No-Issue: two pages of the #5337 umbrella, which stays open.

Testing

Web only, no Rust touched. From web/:

  • npm test — 491 passed
  • npm run check — clean
  • node scripts/check-locales.mjs — passes, and fails if zh drops a key or {date}

Rendered output, main vs this branch, both pages in all 18 locales: body text
and <title>/description/og:/twitter: meta identical. As a control, the
same comparison flags a single removed space after 于 in the zh date line, and
a one-character change to the zh description.

Checklist

  • This PR adds a new layer/module/abstraction — n/a
  • Updated docs or comments as needed — n/a
  • Added or updated tests where relevant
  • Verified TUI behavior manually if UI changes — n/a
  • Harvested/co-authored credit uses a GitHub numeric noreply address

@Lstarsky0
Lstarsky0 requested a review from Hmbown as a code owner September 23, 2026 04:03
@github-actions

Copy link
Copy Markdown
Contributor

Thanks @Lstarsky0 for taking the time to contribute.

This repository is observing a maintainer-managed PR intake gate in dry-run mode, so this pull request is staying open. This note helps maintainers prepare the allowlist before any enforcement is considered.

Please read CONTRIBUTING.md for the expected contribution shape. A maintainer can grant recurring PR access by commenting /lgtm on a pull request.

…ne (Hmbown#5337)

Copy moved verbatim; the binding English terms stay in lib/legal-copy.
Rendered body, title and meta are unchanged across all 18 locales, and
CEILING drops to the new count of 15. check-locales now covers both new
dictionaries, plus docs-work.ts, which the docs/work migration left out.

Signed-off-by: Lstarsky0 <59827030+Lstarsky0@users.noreply.github.com>
timothybrush pushed a commit to timothybrush/DeepSeek-TUI that referenced this pull request Sep 24, 2026
The RSS budget and offline eval ran inside Test for every trusted event,
assuming the warm self-hosted Mac. With CW_SELF_HOSTED_MAC off, a trusted
PR's macOS leg is a cold GitHub-hosted Mac, where Test alone took 77-80
minutes on 2026-09-23 (Hmbown#6431, Hmbown#6417) and the two extra steps would pass
the 90-minute limit. Route both steps by runner, not trust: inside Test
only on the self-hosted Mac, otherwise in the parallel macos-budget job.
Raise Test's timeout to 120 minutes for cold hosted Macs.

This makes the existing kill switch safe to use: the single self-hosted
runner had 14 queued runs and dropped jobs with "lost communication".

Verification: actionlint with CI's flags (-ignore SC2129/SC2221/SC2222)
clean. No tests run; workflow-only change, CI is the proof.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@Hmbown
Hmbown merged commit ccdd6a6 into Hmbown:main Sep 24, 2026
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants