Skip to content

fix(color-manager): preserve manually-set vertex colors in Color by Vertex #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EdwardMoyse merged 1 commit into from
Jul 26, 2026
Merged

fix(color-manager): preserve manually-set vertex colors in Color by Vertex #971

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/phoenix-event-display/src/managers/three-manager/color-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,16 @@ export class ColorManager {
return;
}

// Deterministic distinct color per vertex (golden ratio hue steps),
// unless the vertex has an explicit color.
// Use explicit vertex color if set in event data, otherwise the current
// material color (e.g. set by the user via the UI), otherwise deterministic
// distinct color per vertex (golden ratio hue steps).
const materialColor =
vertexObject instanceof Mesh
? ((vertexObject.material as any)?.color as Color | undefined)
: undefined;
const vertexColor =
vertexObject.userData.color ??
materialColor ??
new Color().setHSL((vertexIndex * 0.618034) % 1, 0.9, 0.55);

setColorForObject(vertexObject, vertexColor);
Expand Down
Loading