fix(color-manager): preserve manually-set vertex colors in Color by Vertex - #971
Merged
Merged
Conversation
…ertex When applying "Color by Vertex", the vertex color should come from: 1. Explicit vertex color in the event data (userData.color) 2. Current material color (if user has manually set it via the UI) 3. Deterministic golden-ratio color (fallback) Previously, the code skipped step 2, so manually-set colors (e.g. green vertices) were replaced with deterministic colors when applying Color by Vertex to linked tracks. Now those manual colors are preserved. Fixes the issue where setting Vertices_xAOD to green, then applying Color by Vertex to InDetTrackParticles_xAOD, would result in random-looking colors instead of the green tracks/vertices. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When applying "Color by Vertex", the vertex color should come from:
Previously, the code skipped step 2, so manually-set colors (e.g. green vertices) were replaced with deterministic colors when applying Color by Vertex to linked tracks. Now those manual colors are preserved.
Fixes the issue where setting Vertices_xAOD to green, then applying Color by Vertex to InDetTrackParticles_xAOD, would result in random-looking colors instead of the green tracks/vertices.