Move ticker input into the header, drop the collapse toggle - #13
Merged
Merged
Conversation
The `ticker` input, Run button, and validation feedback now render inside .site-header (between the brand and the theme toggle) instead of a separate sticky bar below it. Since .site-header stays dark in both themes, the bar's own controls pick up light-on-dark styling instead of the light-theme tokens; the ticker-badges and error alert keep their self-contained colors unchanged. The collapse/expand toggle is removed entirely along with its dead weight: static/parametersBar.js, the chevron/summary markup, the localStorage['parametersBarCollapsed'] persistence, and the tests that covered it (tests/unit/parametersBar.test.js). Coverage.test.js and test_frontend_api.py are updated to match. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tickerinput, Run button, and validation feedback now render inside.site-header's "Market Dashboard" area (between the brand and the theme toggle) instead of a separate sticky bar below the header.▸ ^SPXsummary,localStorage['parametersBarCollapsed']persistence,static/parametersBar.js, and its dedicated test file) — the bar is now always visible..site-headerstays dark in both themes, the moved controls (label, input) pick up light-on-dark styling; the ticker-badges and error alert keep their existing self-contained colors.tests/test_frontend_api.py,tests/unit/coverage.test.js, anddocs/frontend_architecture.mdto match.Test plan
npx vitest run— 15 files / 189 tests passpytest -m "not network" --ignore=tests/e2e— full suite passespytest tests/test_frontend_api.py— passespython scripts/doc_guard.py/python scripts/arch_metrics.py --check— clean🤖 Generated with Claude Code