Center the ticker box and show validity as ✅/❌ beside it - #15
Merged
Merged
Conversation
.header-inner becomes a 3-column grid (brand / parameters-bar / actions) instead of a 2-child flexbox, so the ticker input is genuinely centered on the header row rather than left-packed next to the brand. The Parameters bar's row is flex-wrap: nowrap on desktop specifically because a wrapping flex container's intrinsic width is only its widest single child, not the sum — that was starving the grid's auto column and wrapping Run onto its own line; wrap comes back under the 768px breakpoint, where the row is stretched to the header's full width instead of being intrinsically sized. Ticker validity feedback is now a single ✅/❌ glyph per ticker (with the ticker + price as its title tooltip), rendered immediately right of the input via #ticker-badges, replacing both the old (never-rendered — main.js was querying a #ticker-badges id no element had) colored pill badges and the "N ticker(s) valid" sentence that used to sit below the input. The corresponding dead CSS (.ticker-validation*, the old .ticker-badge pill styles) is removed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #13 (merged), same header ticker bar.
.header-inneris now a 3-column grid (brand / parameters-bar / actions) so the ticker input is genuinely centered on the header row, not just left-packed next to the brand.#ticker-badges— replacing both the old colored pill badges (which, turns out, never actually rendered:main.jswas querying a#ticker-badgesid no element had) and the "N ticker(s) valid" sentence that used to sit below the input. That sentence and its dead CSS are removed..parameters-bar-mainisflex-wrap: nowrapon desktop specifically: a wrapping flex container's intrinsic width is only its widest single child (not the sum), which was starving the grid'sautocolumn and wrapping the Run button onto its own line. Wrap comes back under the 768px breakpoint, where the row is stretched to the header's full width instead of being intrinsically sized, so wrapping there is safe.Test plan
npx vitest run— 15 files / 189 tests passpytest -m "not network" --ignore=tests/e2e --maxfail=0— full suite passes (onetest_readiness.pyfailure on the first run was a pre-existing thread-timing flake, confirmed by re-running it in isolation; unrelated file, not touched here)pytest tests/test_frontend_api.py— passespython scripts/doc_guard.py/python scripts/arch_metrics.py --check— clean🤖 Generated with Claude Code