Add production Memory Editor search engine - #113
Closed
H3nb wants to merge 2 commits into
Closed
Conversation
Owner
Author
|
Superseded by PR 115 after the requested branch rename to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First of two PRs for the production Memory Editor described in H3nb/JL-Mod-Plus#108.
:memory_engineservice and one remote read-only native scan core;/proc/self/maps+mincore()collection in a thin non-exported:midletbridge;process_vm_readv()access with an 8-byte target-owned capability probe before reporting support;=,!=,>,<,>=,<=, Between), Unknown snapshots, all requested primitive types including Auto, relative/delta predicates, previous-vs-initial comparison, bounded history/Undo, cancellation, pagination, and engine-ownedCandidateIds;The implementation is intentionally direct: primitive AIDL buffers, a single worker, flat native stores, and immutable committed states. It adds no DI framework, database, shared-memory layer, local scanner fallback, or product UI.
Safety and containment
uintptr_tarithmetic are used;Long.MIN_VALUEtoLong.MAX_VALUE;Validation
Passed locally:
cppcheck --enable=warning,performance,portability --std=c++17 ... app/src/main/cpp/memory:app:lintEmulatorDebug:app:testEmulatorDebugUnitTest:dexlib:testDebugUnitTest:app:assembleEmulatorDebug:app:assembleEmulatorDebugAndroidTest:app:assembleEmulatorReleaselibjlmem.soandlibjlmem_target.soare packaged for all four ABIsThe Android instrumentation probe is compiled but not executed yet because no ADB device is connected. Physical Android 16 validation with Green Farm, Bounce, and additional corpus samples remains a merge/stable gate.
Deliberately deferred to PR 2
Audit recommendations for PR 2