Add safe Memory Editor controls and runtime UI - #116
Closed
H3nb wants to merge 12 commits into
Closed
Conversation
Owner
Author
|
Superseded by PR #117. The complete Memory Editor foundation + runtime UI stack is now consolidated there so review, CI, fixes, and benchmarking can happen against one authoritative branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is PR 2 of 2 for the production Memory Editor milestone in #108. It is intentionally stacked on PR #115; review and merge that foundation first, then retarget this PR to
alpha.MicroActivity, reachable from the existing runtime Back menu;MagnifyingGlassandXvectors and includes the complete MIT notice in both attribution surfaces.Core scaling refinements
(type, identity)keys actually being recovered, avoiding the previous old×fresh comparison path and avoiding a full index of a large fresh pool;Safety properties audited
:memory_engineworker, writes only on rule violation, and independently pauses unsafe records;Validation
The stacked PR remains mergeable on top of current PR #115. The previous local validation covered:
:app:lintEmulatorDebug:app:testand:dexlib:test:app:validateEmulatorDebugScreenshotTest:app:assembleEmulatorDebug:app:assembleEmulatorDebugAndroidTest:app:assembleEmulatorReleaseincluding R8/resource shrinkingarm64-v8a,armeabi-v7a,x86, andx86_64PR #115 head
736ec71bpasses Android CI. GitHub has not emitted a workflow run for the latest PR #116 connector-authored head yet, so the new batch-recovery/checkpoint changes still require the normal CI/build pass before merge.Draft / release-gate limitations
No ADB device was attached in this environment. The Android 16 physical capability probe, Bounce/Green Farm workflows, multi-edit partial-failure behavior, relocation, Freeze identity-loss behavior, and soak/RSS acceptance matrix from #108 remain mandatory before this can be called stable.
The 32-candidate write/recovery caps and 750 ms Freeze interval remain deliberately conservative provisional values. Batch recovery is now shared across the bounded recovery set; physical profiling should verify its latency and RSS before changing those caps.
Select all resultsis also intentionally not exposed while a session may contain up to two million typed candidates; the current safe UI offers Select visible and Invert visible, while all mutation paths remain explicit and bounded.