Skip to content

Release 3.5.1 #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guys-inc-ops merged 1 commit into from
Aug 28, 2026
Merged

Release 3.5.1 #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"productName": "GitHub Desktop",
"bundleID": "com.github.GitHubClient",
"companyName": "GitHub, Inc.",
"version": "3.5.0",
"version": "3.5.1",
"main": "./main.js",
"repository": {
"type": "git",
Expand Down
3 changes: 3 additions & 0 deletions changelog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
{
"releases": {
"3.5.1": [
"[Fixed] The sign-in code is now shown when signing in from inside the app. Only the first-run welcome flow displayed it, so re-authenticating opened a browser asking for a code that was never on screen"
],
"3.5.0": [
"[Added] Sign in to GitHub.com using the OAuth device flow: Desktop shows a one-time code to enter in your browser, instead of handing off through a redirect",
"[Fixed] The published packages no longer contain an OAuth client secret. Desktop authenticates as a public client, so no secret is built into the application",
Expand Down
12 changes: 10 additions & 2 deletions script/generate-release-notes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,14 @@ function formatReleaseNote(note: ReleaseNoteEntry): string {
return template.trim()
}

/**
* Empty sections are omitted rather than rendered with a "TODO" placeholder.
*
* The placeholder was a prompt for whoever edited the draft release by hand.
* These notes are published without that pass, so an empty section reached
* users as a literal "## Improved / TODO" - a patch release that fixes one
* thing genuinely has nothing under the other headings.
*/
function renderSection(
name: string,
items: Array<ReleaseNoteEntry>,
Expand Down Expand Up @@ -241,7 +249,7 @@ function generateDraftReleaseNotes(
return `
${renderSection('New', releaseNotesGroups.new)}
${renderSection('Added', releaseNotesGroups.added)}
${renderSection('Fixed', releaseNotesGroups.fixed, false)}
${renderSection('Improved', releaseNotesGroups.improved, false)}
${renderSection('Fixed', releaseNotesGroups.fixed)}
${renderSection('Improved', releaseNotesGroups.improved)}
${renderSection('Removed', releaseNotesGroups.removed)}`
}
Loading