Release 3.5.1 - #40
Merged
Merged
Conversation
Ships the sign-in fix from #39. 3.5.0 could not be signed into from inside the application: the device code was fetched and never rendered by the re-authentication dialog, so the browser opened asking for a code that was nowhere on screen. Also stops the notes generator publishing "TODO". Empty sections rendered a placeholder that existed as a prompt for whoever edited the draft release by hand; we publish without that pass, so a patch release fixing one thing would have shipped a literal "## Improved / TODO" to users. Empty sections are now omitted. Verified that 3.4.9-linux1 still renders its ten upstream issue links with no placeholders.
Cam8863
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release prep for the sign-in hotfix in #39. Ready to tag
release-3.5.1-linux1once merged (confirmed free — 3.5.x is untouched by the 301 inherited tags).Changes
app/package.json→3.5.1changelog.json→ 3.5.1 entry describing the fix in user termsAlso: the notes generator would have published "TODO"
Rendering the 3.5.1 notes produced this:
renderSectionwas called withomitIfEmpty: falsefor Fixed and Improved, so an empty section rendered a literalTODO. That placeholder is a prompt for whoever edits a draft release by hand — upstream's workflow. We publish the generated body without that pass, so a patch release that fixes exactly one thing would ship## Improved / TODOto users.Empty sections are now omitted.
Regression checked, since this touches shared code:
3.4.9-linux1still renders 10 upstream issue links and 0 placeholders.Rendered 3.5.1 notes
tsc,eslint(it lintschangelog.json), andprettierall clean.After this
Tag → build → publish → apt sync, then I verify the published
.debactually renders the code in both sign-in surfaces rather than trusting the build. Guys-Inc-Public/guysinc-web#7 still needs retargeting from 3.5.0 to 3.5.1 before it merges.