Skip to content

Release as 3.5.0: 3.4.10 through 3.4.14 are already tagged #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Cam8863 merged 1 commit into from
Aug 27, 2026
Merged

Release as 3.5.0: 3.4.10 through 3.4.14 are already tagged #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"productName": "GitHub Desktop",
"bundleID": "com.github.GitHubClient",
"companyName": "GitHub, Inc.",
"version": "3.4.10",
"version": "3.5.0",
"main": "./main.js",
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion changelog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"releases": {
"3.4.10": [
"3.5.0": [
"[Added] Sign in to GitHub.com using the OAuth device flow: Desktop shows a one-time code to enter in your browser, instead of handing off through a redirect",
"[Fixed] The published packages no longer contain an OAuth client secret. Desktop authenticates as a public client, so no secret is built into the application",
"[Improved] Upgrade Electron to v39.8.10, from v32.1.2, picking up seven major versions of Chromium security fixes",
Expand Down
2 changes: 1 addition & 1 deletion docs/known-issues.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ covers what you are granting.

### Signing in asks for a code instead of opening a sign-in page

This is expected from 3.4.10 onwards, and is not an error.
This is expected from 3.5.0 onwards, and is not an error.

Desktop now signs in using the OAuth **device flow**: it shows a one-time code,
you open the link in a browser, enter the code, and approve the request. The
Expand Down
Loading