Release as 3.5.0: 3.4.10 through 3.4.14 are already tagged - #38
Merged
Merged
Conversation
The version chosen in #37 cannot be used. This repository inherited 301 release-* tags from the lineage it forked from, running up to release-3.4.14-linux1, and release-3.4.10-linux1 has existed since 2025-02-09. Release tags are immutable under the org ruleset, so none of 3.4.10 to 3.4.14 can be reused. I checked dpkg and semver ordering when picking 3.4.10 and did not check whether the tag was free. 3.5.0 rather than 3.4.15. Both are free and both are clean in dpkg and semver ordering, but either one decouples this fork's numbering from upstream's - the difference is only whether that is visible. A minor bump says so, where skipping five patch numbers looks like an accident. It is also the more honest description of what is in here: seven major versions of Electron and a rewritten sign-in are not a patch release. 3.4.9-linux2 was the truthful alternative and was rejected on cost. It is a semver prerelease, so it sorts *below* 3.4.9 - release-notes.ts builds a SemVer from the running version and filters for releases newer than it, which would make the app offer 3.4.9's notes as "what's new" to someone who had just upgraded past it. Release notes re-rendered for 3.5.0-linux1: 0 unparsed entries.
Cam8863
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version chosen in #37 cannot be used, and this has to land before anything can be tagged.
What I missed
This repository inherited 301
release-*tags from the lineage it forked from, running up torelease-3.4.14-linux1:release-*is immutable under the org ruleset, so 3.4.10 through 3.4.14 are all unusable. Creating the tag failed with422 Reference already exists. I checked dpkg ordering and semver ordering when picking 3.4.10 in #37, and did not check that the tag was free.Why 3.5.0
3.4.15and3.5.0are both free and both clean in dpkg and semver ordering. Either one decouples this fork's numbering from upstream's — the only difference is whether that is visible. A minor bump states it; skipping five patch numbers looks like an accident. It also describes the contents more honestly: seven major versions of Electron and a rewritten sign-in are not a patch release.3.4.9-linux2was the truthful option — second Linux packaging of upstream 3.4.9, matching the inheritedrelease-3.4.0-linux2precedent — and I rejected it on cost. It is a semver prerelease, so it sorts below3.4.9.app/src/lib/release-notes.ts:118builds aSemVerfrom the running version and filters for releases newer than it, sosemver.gt('3.4.9', '3.4.9-linux2')being true would make the app show 3.4.9's notes as "what's new" to someone who had just upgraded past it. It would also have needed a further patch to the notes script so a non--linux1tag finds its own changelog entry.Changes
app/package.json→3.5.0changelog.jsonkey3.4.10→3.5.0(entries unchanged)docs/known-issues.md— the device-flow section said "expected from 3.4.10 onwards"Notes re-rendered for
3.5.0-linux1: 0 unparsed entries.eslint(which lintschangelog.json) andprettierclean.Next tag will be
release-3.5.0-linux1, which is free. Guys-Inc-Public/guysinc-web#7 needs the same correction before it merges.