Repository navigation
Extend galaxy selection and complete macOS feature support - #299
Merged
Merged
Conversation
# Conflicts: # .github/workflows/ci.yaml # mods/src/patches/parts/mod_settings.cc
Guffawaffle
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables selecting systems at far galaxy zoom without retaining full visual entities. Adds the default-off
graphics.galaxy_extended_selectionsetting and a live Mod Settings toggle. A bounded rolling cache retires unused selection targets; failed UI-owner reads prevent retirement, while valid empty owners and inflated managed list accessors remain supported.Completes the Mac feature support carried by #294: desktop notifications, OPC indicators, fleet/galaxy label controls and fleet-arrival fixes. Includes the newer Mac node-depletion signature and native-hook validation from the fleet-notification source branch. Retains the queue protections, live HUD controls, Mac shortcut editor and corrected Command capture from current play/#302, with one shared zoom/LOD hook owner and SPUD v0.2.0-7.
Includes current play after #302 and #303 landed, preserving both extended galaxy selection and the Galactic Anomaly timer settings. No separate merge of #294 is needed.
Validation: Windows release build; settings, persistence, fleet-arrival, shortcut capture/dispatch and selection-owner failure/metadata fixtures; all 11 example configs; three independent reviews. Fresh platform CI is required for this updated head. Mac runtime reports: Ginger, a Mac user, reported the shortcut editor working on macOS ARM in #295; Mcohall confirmed that zoomed-out system clicks work. The author relayed this confirmation on September 20. These reports establish positive feature smoke, although their tested artifacts are not tied to this latest combined head and its subsequent Command/cache corrections. Current-head regression coverage remains to be recorded for native tap suppression, single dispatch, preview retention past 64 targets, and shortcut restart persistence. Intel Mac runtime remains unconfirmed.
Current play merge validation: all three correction review lanes clear; Windows releasedbg build, settings/selection/fleet-arrival fixtures, timer persistence fixture, all 11 example configs and diff check passed. Fresh platform CI is running; no game deployment or restart for this conflict resolution.