Repository navigation
Bring upstream ship management and empty-shortcut fixes into play - #304
Merged
Merged
Conversation
* feat: arrow navigation to switch docks * feat: enter to assign ship * refactor: match ship names via the game's localized display names Resolves the exact name the game UI shows by looking up the ship's locale id (ILocaId) with identifier ship_name_<id> through the game's Localizer, replacing HullSpec.Name/IdStr matching plus every manual alias. Config entries are matched against that display name so pinned ships and instant-warp filters accept the names used in game (and listed on stfc.space).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings upstream #283 and #290 into current play after fork #299:
Preserves the shared Warp/Jump resolver so the course-button label and confirmation use the same decision. Corrects two issues found in the imported name-matching implementation: convert UTF-16 names to UTF-8 and retain 64-bit localization IDs on Windows. Adds an accented/Cyrillic matching fixture and ID type assertion.
Validation: all three final review lanes clear; Windows releasedbg DLL build, ship-name matching fixture, settings/selection/fleet-arrival fixtures, shortcut dispatch/hint fixture, all 11 example configs, and diff check passed. Native dock/Enter interaction smoke and Mac runtime validation remain outstanding. No deployment or game cycle performed for this integration.
Upstream #263 and #244 are excluded, as requested.