Repository navigation
Conversation
A gene that Parascopy, pypgx or the copy-number engine calls and that step 16b did not read was listed under not_read_owned with its owner only, so it read as answered even when that step never ran. Each entry now names the owner's step (owner_step) and says ran or not run (owner_status), from the file that step writes in the sample folder. The summary-collect goldens of the cases with owned genes gain the two keys; full, nf and stale get a golden for the first time. Bead: clin-25
callability-2-genes collects the base case's folder again and compares every owner_status with a shell test of that step's files; HTML_REPORT run alone, with no owner output, must read not run for every owned gene. Bead: clin-25
…honesty # Conflicts: # CHANGELOG.md
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 55 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Collaborator
Author
|
@coderabbitai review |
Action not completed
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Some hard genes have a step of their own: Parascopy (step 35) for SMN1 and 45 others, pypgx (step 32) for CYP2D6 and seven others, and the copy-number engine for HBA1, HBA2, CYP21A2, HP, CCL3L1, LPA and RHD. When step 16b does not read such a gene,
summary.jsonlists it undernot_read_ownedwith its owner, and the report says "called by a step of their own". That stays true when the owner's step never ran for the sample. The gene then has no answer anywhere, and its coverage line reads as if one exists.Fix
Each
not_read_ownedentry gains two fields:owner_step: the step that calls it (35,32,46or41).owner_status:ranwhen that step wrote its own file in the sample folder, elsenot run.The files are the ones each step writes: a Parascopy table
paralogs/<s>_<table>_copy_number.tsv(not the HBA or Paraphase table, which share the folder),pypgx/<s>_pypgx_summary.tsv(not CPIC's comparison, which shares the folder),paralogs/<s>_hba_copy_number.tsv,_cyp21a2_psv.tsv,_cn_dosage.tsv,lpa/<s>_lpa_kiv2.tsvandbloodtype/<s>_bloodtype.tsv. The Nextflow report task links the same files into the same folders, so both paths agree.Fields are only added. Nothing is renamed or removed. The share already keeps four decimals, so 0.8988 stays 0.8988; a test now pins that. The reports do not show the new fields yet; the display is a separate change.
Decisions:
<folder>/mosdepth/orcoverage/), so the change stays insidesections.rs.rust/crates/og-summary/src/collect/tests.rsis outside this package's file list. Its callability test asserts the exactnot_read_ownedentry, so I added the two fields to its expected value (one line).docs/results/clinvar.mdhas no callability text, so it is unchanged.Goldens touched (summary-collect):
all,all-nfandall-historygain the two keys on each owned entry (54 entries each, nothing else changes).full,nfandstaleget a golden for the first time, because their oracle has no such keys.How it was checked
rust/crates/og-summary/tests/i411_callability_honesty.rs, with the shipped catalog: every owned gene readsnot runwhen no owner file exists (and every owner maps to a step); every one readsranwith each owner file present, in the Nextflow layout; HBA's and Paraphase's tables do not count as Parascopy, and CPIC's comparison does not count as pypgx; an SMN1 share of 0.8988 stays 0.8988.no owner_step in Object({"gene": Str("RHD"), "owner": Str("cn_loci:RHD"), ...}). The share test passes on main too, because main already rounds to four decimals.cargo test -p og-summary,-p og-render,-p og-facts: all pass.cargo clippy -p og-summary --all-targets -D warningsandcargo fmt --check: clean.scripts/ci/oracle-diff.sh summary-collectagainst the oracle: before the goldens, the six cases differed only by the two new keys; after them, those cases pass.tests/e2e/callability-2-genes.shgains part 3. It collects the base case's folder again and compares eachowner_statuswith a shell test of that step's files. It also checks that HTML_REPORT run alone, with no owner output, readsnot runfor every owned gene. I checked the comparison on a synthetic folder: it passes, and a planted wrong status on SMN1 is reported.Bead: clin-25