Skip to content

fix(callability): say when a gene's own step never ran instead of showing coverage alone - #285

Open
geiresx wants to merge 4 commits into
mainfrom
pgp/i411-callability-honesty
Open

geiresx wants to merge 4 commits into
mainfrom
pgp/i411-callability-honesty

Conversation

@geiresx

@geiresx geiresx commented Nov 20, 2026

Copy link
Copy Markdown
Owner

A gene that Parascopy, pypgx or the copy-number engine calls and that
step 16b did not read was listed under not_read_owned with its owner
only, so it read as answered even when that step never ran. Each entry
now names the owner's step (owner_step) and says ran or not run
(owner_status), from the file that step writes in the sample folder.

The summary-collect goldens of the cases with owned genes gain the two
keys; full, nf and stale get a golden for the first time.

Bead: clin-25
callability-2-genes collects the base case's folder again and compares
every owner_status with a shell test of that step's files; HTML_REPORT
run alone, with no owner output, must read not run for every owned gene.

Bead: clin-25
@coderabbitai

coderabbitai Bot commented Nov 20, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants