Repository navigation
Conversation
og report charts --summary IN --charts-json OUT writes what bin/render_report.py --charts-json writes, byte for byte, and prints the same Sections line, so both run with the same arguments. The specs are built once (charts::build) for the HTML report (charts::figure) and the live page (charts::json). Bead: D1
Every non-browser check of tests/test_report_charts.py now runs on og report charts in rust/crates/og-render/tests/charts.rs, each with its red control, plus frozen hashes of the oracle's charts JSON on the fixture and five changed copies. The Python file keeps only the live page's browser check, which needs the Python live server. Bead: D1
Bead: D1
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 55 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
… figures Old checks 7 and 8 test what bin/render_report.py still ships: each chart once in its section below the caveat, every anchor resolving, and two renders giving the same charts file. og report render does not embed the figures yet, so they stay in Python until html.rs does. The charts.rs header and the changelog now say which checks moved.
Collaborator
Author
|
@coderabbitai review |
Action not completed
|
geiresx
pushed a commit
to geiresx/OwnGenome
that referenced
this pull request
Nov 20, 2026
geiresx
pushed a commit
to geiresx/OwnGenome
that referenced
this pull request
Nov 20, 2026
…rpus summaries GeiserX#537 ported the charts but left its corpus rows out of the parity list, so CI held the charts only on the six frozen summaries. One report-charts case per report-render summary, compared as JSON, and the oracle row at 65095e9. scripts/ci/oracle-diff.sh report-charts: all 616 items in 154 cases agree; a planted key rename in og's charts file makes both cases it touches differ.
geiresx
pushed a commit
to geiresx/OwnGenome
that referenced
this pull request
Nov 20, 2026
It writes the chart specs as render_report.py --charts-json does (GeiserX#537); no step calls it yet.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The report's five charts (ClinVar stars, the genome ideogram, the heteroplasmic chrM sites, fine-grained ancestry and the PRS percentiles) are still built by
bin/report_charts.py. The HTML report and the live page's charts plugin both read them from there. 1.0.0 ships with no owned Python, so the charts need a Rust builder before the reports can switch to og.Fix
og report charts --summary summary.json --charts-json <sample>_charts.jsonbuilds the five chart specs and their inline SVG inog-render(rust/crates/og-render/src/charts/). The specs are built once:charts::jsongives the live page's file, andcharts::figuregives the line the HTML report puts under a section's caveat.str(),int(),float(), Python'sminandmax), draws in Python's arithmetic order, and takes every caveat fromog_render::notesby name. So it writes whatbin/render_report.py --charts-jsonwrites, byte for byte, and prints the sameSections:line.og report chartstakesrender_report.py's--summaryand--charts-json; it does not take the report's other arguments (-o,--sample,--sample-dirand the rest).og_summary ... roh::ROH_MIN_BP). The GRCh38 lengths are public (charts::GRCH38) for the live family page.tests/test_report_charts.pyand the anchor of a hit past the table moved torust/crates/og-render/tests/charts.rs(18 tests). They checkog report charts. Each detector also runs on a broken input and must catch it. A frozen vector (FNV-1a of the oracle's charts JSON) holds the output to whatbin/report_charts.pywrote at 65095e9, on the fixture and five changed copies.tests/test_report_charts.pykeeps the checks of whatbin/render_report.pystill ships, with their code unchanged:<script>, everyhref="#..."resolves to an id, each of the five charts sits once in its section below that section's caveat, and the hits table carriesid="clinvar-hits"with at least 50 rows;generated_utc, with its schema version and the five chart ids;No output changes: no step calls
og report chartsyet, andbin/render_report.pystill writes the charts until the reports switch to og.Decisions
og report renderdoes not embed the figures yet: wiringcharts::figureinto the section frames is a change tohtml.rs, outside this package. The lane that does it must port check 7 to its cargo tests, as the spec of where a figure goes.charts.json og's file needsog-browserandog-renderin one crate's dev-dependencies, and neitherCargo.tomlis in this package's files.tests/parity/cases.tsvandoracle.refare not in this package's files. The rows are mechanical, because the verb takes the oracle's own arguments:report-charts <case> gen:report-corpus.sh --summary <case>.json --charts-json <case>_charts.json <case>_charts.json json PYTHON_IMAGE, with the oracle rowreport-charts 65095e975bea01c74ed92a4f1b8c1bd00d05caaa file:bin/render_report.py sh ./oracle.sh report charts. Until they land, CI holds the parity on the 6 frozen summaries only.og report chartsfrom the stub list indocs/rust.md:45, and changerust/README.md:25to say charts are ported (no caller yet).og run deltasees no change for the addedheteroplasmic_sites) is dropped.og run deltacompares section states and the ClinVar, CPSR, CPIC, CYP2D6 and PRS data only, so no mito field can make a change.How it was checked
tests/parity/gen/report-corpus.shwrote 154 summaries. For each,render_report.pyat the oracle commit (--charts-json, through the generator'soracle.sh) andog report chartswrote the same file, byte for byte, and the same stdout:n=154 json-same=154 byte-same=154 bad=0. Those summaries hold 25 ClinVar charts, 26 genome charts (up to 16 marks), 26 mito charts, 14 ancestry charts, 15 PRS strips and 3 PRS text charts.the_charts_json_is_what_the_python_wroteand makes 14 corpus files differ.cargo test -p og-render: all suites green,charts.rs18 passed.cargo clippy -p og-render --all-targets -- -D warningsandcargo fmt --checkare clean.python3 tests/test_report_charts.pywith Chrome: all 18 checks passed (checks 7, 8 and 10, each with its red control).<figure class="chart">in the ClinVar section gives[FAIL] 7. section clinvar: one chart, below its caveat -- (236, 490)and1 failed.tests/test_report_charts.py,PASS) https://github.com/geiresx/OwnGenome/actions/runs/44728746755 , Lint https://github.com/geiresx/OwnGenome/actions/runs/44728774245 , Personal data https://github.com/geiresx/OwnGenome/actions/runs/44728812418 , Docs https://github.com/geiresx/OwnGenome/actions/runs/44728849172 , Nextflow https://github.com/geiresx/OwnGenome/actions/runs/44728880608 , Container Test https://github.com/geiresx/OwnGenome/actions/runs/44728911711 , Freshness https://github.com/geiresx/OwnGenome/actions/runs/44728938574 , Rust https://github.com/geiresx/OwnGenome/actions/runs/44728968235 . E2E runs once on the landing batch tip.Bead: D1