Skip to content

refactor(report): build chart specs once in og-render - #279

Open
geiresx wants to merge 4 commits into
mainfrom
pgp/port-report-charts
Open

geiresx wants to merge 4 commits into
mainfrom
pgp/port-report-charts

Conversation

@geiresx

@geiresx geiresx commented Nov 20, 2026

Copy link
Copy Markdown
Owner

og report charts --summary IN --charts-json OUT writes what
bin/render_report.py --charts-json writes, byte for byte, and prints the
same Sections line, so both run with the same arguments. The specs are
built once (charts::build) for the HTML report (charts::figure) and the
live page (charts::json).

Bead: D1
Every non-browser check of tests/test_report_charts.py now runs on og
report charts in rust/crates/og-render/tests/charts.rs, each with its red
control, plus frozen hashes of the oracle's charts JSON on the fixture and
five changed copies. The Python file keeps only the live page's browser
check, which needs the Python live server.

Bead: D1
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

… figures

Old checks 7 and 8 test what bin/render_report.py still ships: each chart once in its section below the caveat, every anchor resolving, and two renders giving the same charts file. og report render does not embed the figures yet, so they stay in Python until html.rs does. The charts.rs header and the changelog now say which checks moved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants