Repository navigation
Conversation
og report charts --summary IN --charts-json OUT writes what bin/render_report.py --charts-json writes, byte for byte, and prints the same Sections line, so both run with the same arguments. The specs are built once (charts::build) for the HTML report (charts::figure) and the live page (charts::json). Bead: D1
Every non-browser check of tests/test_report_charts.py now runs on og report charts in rust/crates/og-render/tests/charts.rs, each with its red control, plus frozen hashes of the oracle's charts JSON on the fixture and five changed copies. The Python file keeps only the live page's browser check, which needs the Python live server. Bead: D1
Bead: D1
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
… figures Old checks 7 and 8 test what bin/render_report.py still ships: each chart once in its section below the caveat, every anchor resolving, and two renders giving the same charts file. og report render does not embed the figures yet, so they stay in Python until html.rs does. The charts.rs header and the changelog now say which checks moved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GeiserX#537