Skip to content

Apply jafranc review comments on PR#251 (euler surface) #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jafranc wants to merge 2 commits into
base: feat/bd713/eulerSurface
Choose a base branch
from
+14 −2
Open

Apply jafranc review comments on PR#251 (euler surface) #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f354581
Apply jafranc review comments on PR#251 (euler surface)
claude May 29, 2026
50386f5
Update eulerParsing.py
jafranc May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions mesh-doctor/src/geos/mesh_doctor/actions/euler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ class SurfaceComponent:
numBoundaryEdges: int
numNonManifoldEdges: int
interpretation: str
nonManifoldEdgeEndpoints: tuple[ tuple[ int, int ], ...] = field( default_factory=tuple )


@dataclass( frozen=True )
Expand Down Expand Up @@ -152,6 +153,7 @@ def __countConnectedComponents( mesh: vtk.vtkUnstructuredGrid ) -> int:
cf = vtk.vtkConnectivityFilter()
cf.SetInputData( mesh )
cf.SetExtractionModeToAllRegions()
cf.SetRegionIdAssignmentMode( vtk.vtkConnectivityFilter.CELL_COUNT_DESCENDING )
Comment thread
jafranc marked this conversation as resolved.
cf.ColorRegionsOn()
cf.Update()
return cf.GetNumberOfExtractedRegions()
Expand Down Expand Up @@ -229,6 +231,7 @@ def __surfaceComponentsFromColored( colored: vtk.vtkUnstructuredGrid ) -> list[
"""Compute (V, E, F, chi, boundary, non-manifold) per RegionId of a colored 2D mesh."""
rid = vtk_to_numpy( colored.GetCellData().GetArray( "RegionId" ) ).astype( np.int64 )
cells = colored.GetCells()
# GetConnectivityArray / GetOffsetsArray require VTK 9+
conn = vtk_to_numpy( cells.GetConnectivityArray() ).astype( np.int64, copy=False )
off = vtk_to_numpy( cells.GetOffsetsArray() ).astype( np.int64, copy=False )

Expand All @@ -251,7 +254,8 @@ def __surfaceComponentsFromColored( colored: vtk.vtkUnstructuredGrid ) -> list[
E = len( edgeCount )
F = int( len( sel ) )
bE = sum( 1 for c in edgeCount.values() if c == 1 )
nm = sum( 1 for c in edgeCount.values() if c > 2 )
nmEdges = tuple( ek for ek, c in edgeCount.items() if c > 2 )
nm = len( nmEdges )
Copy link
Copy Markdown
Contributor

@bd713 bd713 May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea. Are these expressed as indices from the original mesh numbering? If not, we may need a reverse mapping to make the information more readily useful.

chi = V - E + F
components.append(
SurfaceComponent( componentId=int( regionId ),
Expand All @@ -262,7 +266,8 @@ def __surfaceComponentsFromColored( colored: vtk.vtkUnstructuredGrid ) -> list[
eulerCharacteristic=chi,
numBoundaryEdges=bE,
numNonManifoldEdges=nm,
interpretation=__interpretSurface( chi, bE, nm ) ) )
interpretation=__interpretSurface( chi, bE, nm ),
nonManifoldEdgeEndpoints=nmEdges ) )
return components


Expand Down
7 changes: 7 additions & 0 deletions mesh-doctor/src/geos/mesh_doctor/parsing/eulerParsing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,13 @@ def __displaySurfaceGroup( g: SurfaceGroup ) -> None:
setupLogger.results( " " + f"{c.componentId:>5} {c.numCells:>9,} {c.numVertices:>8,} {c.numEdges:>8,} "
f"{c.numFaces:>8,} {c.eulerCharacteristic:>5} {c.numBoundaryEdges:>6,} "
f"{c.numNonManifoldEdges:>4,} {c.interpretation}" )
if c.nonManifoldEdgeEndpoints:
_MAX_DISPLAY = 10
shown = c.nonManifoldEdgeEndpoints[ :_MAX_DISPLAY ]
setupLogger.results( " non-manifold edge endpoints (point id pairs): "
+ ", ".join( f"({a},{b})" for a, b in shown )
+ ( f" … (+{len(c.nonManifoldEdgeEndpoints)-_MAX_DISPLAY} more)"
if len( c.nonManifoldEdgeEndpoints ) > _MAX_DISPLAY else "" ) )
if len( g.components ) > 1:
setupLogger.results( f" WARNING: {len(g.components)} components — verify isolated cells" )

Expand Down
Loading