Apply jafranc review comments on PR#251 (euler surface)#256
Open
jafranc wants to merge 2 commits into
Open
Conversation
- Add SetRegionIdAssignmentMode(CELL_COUNT_DESCENDING) after SetExtractionModeToAllRegions() in __countConnectedComponents so regions are ordered largest-first (suggestion on line 154). - Add comment that GetConnectivityArray/GetOffsetsArray require VTK 9+ (comment on line 233). - Store non-manifold edge point-id pairs in SurfaceComponent and display them (up to 10) in the results output so users know exactly where non-manifold edges are located (question on line 249). https://claude.ai/code/session_01GwpNNFQRPhb26XMCFHJtts
jafranc
added
flag: ready for review
test-geos-integration
bd713
reviewed
May 29, 2026
| bE = sum( 1 for c in edgeCount.values() if c == 1 ) | ||
| nm = sum( 1 for c in edgeCount.values() if c > 2 ) | ||
| nmEdges = tuple( ek for ek, c in edgeCount.items() if c > 2 ) | ||
| nm = len( nmEdges ) |
Contributor
There was a problem hiding this comment.
I like the idea. Are these expressed as indices from the original mesh numbering? If not, we may need a reverse mapping to make the information more readily useful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetRegionIdAssignmentMode(CELL_COUNT_DESCENDING) after SetExtractionModeToAllRegions()in__countConnectedComponentsso regions are ordered largest-first (suggestion on line 154).GetConnectivityArray/GetOffsetsArray require VTK 9+(comment on line 233).SurfaceComponentand display them (up to 10) in the results output so users know exactly where non-manifold edges are located (question on line 249).