Repository navigation
feat(diagnostics): refresh network context, connect errno classes and MP badge family (#984) - #1668
Merged
Merged
Conversation
This was referenced Nov 16, 2026
XaaT
force-pushed
the
feat/984-p2a-telemetry
branch
from
November 16, 2026 20:29
3110602 to
89a5605
Compare
… MP badge family (#984) Add the telemetry the #984 analysis found missing, without touching the flags repository logic: - foreground/background state at the start and end of each flags refresh, plus the transitions during it (bounded relative timeline); - network events during an active refresh (availability, loss, validated and transport changes, data saver and battery saver at start), from a shared callback registered only while a refresh runs and always unregistered in finally; no SSID, carrier, address or network id; - closed errno categories for failed connection attempts (refused, unreachable, network down, timeout, other), read from a bounded cause chain, never from exception messages; - a distinct html:mp-list family for forum1.php?cat=prive and an mp-badge intent on the unread-badge poll, so a badge refresh is no longer read as user navigation; - a bounded sample of isolated successful calls outside refresh bursts (two per minute, overlap tracked for the whole call); - per-refresh counts of calls versus connection attempts. Docs: diagnostics guide lists the new fields and their limits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X7pvomKHW15zFqZ5T6WA6a
XaaT
force-pushed
the
feat/984-p2a-telemetry
branch
2 times, most recently
from
November 16, 2026 20:48
d0a74e7 to
a25a8fd
Compare
…e-batch merge (#984) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X7pvomKHW15zFqZ5T6WA6a
XaaT
force-pushed
the
feat/984-p2a-telemetry
branch
from
November 16, 2026 21:00
a25a8fd to
08bd4e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #984 (flags refresh failing on cellular). Stacked on #1667 (socle). Telemetry only: the refresh, navigation, MP badge and mutations behave exactly as before; no new request, no new Android permission.
The #984 analysis (Fable and Astra, 15/11) could not tell the competing explanations apart with the current exports. This adds what was missing:
validatedand transport changes, data saver and battery saver at start. One shared callback, registered only while a refresh runs, always unregistered infinally. No SSID, carrier, address or network id is exported.forum1.php?cat=privegets its ownhtml:mp-listfamily, and the unread-badge poll carries anmp-badgeintent, so a badge refresh is no longer read as user navigation (the 14/11 "navigation stuck in the burst" was most likely the badge).Docs:
docs/guides/diagnostics.mdlists the new fields and their limits.Validation
31106026c: GREEN, 7 622 tests, 0 failure (--max-workers=3; an earlier run hit the box memory floor, another hit the known flakyMessageCardReadingParityTest, Test instable : MessageCardReadingParityTest > body stays selectable after a full width toggle #1646).Rebased on the socle
FlagRefreshDiagnosticsTest; both kept.PR générée par Claude (Opus 5.5) à la demande de @xatrix.
🤖 Generated with Claude Code
https://claude.ai/code/session_01X7pvomKHW15zFqZ5T6WA6a