Skip to content

feat(diagnostics): refresh network context, connect errno classes and MP badge family (#984) - #1668

Merged
XaaT merged 2 commits into
devfrom
feat/984-p2a-telemetry
Nov 16, 2026
Merged

XaaT merged 2 commits into
devfrom
feat/984-p2a-telemetry

Conversation

@XaaT

@XaaT XaaT commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Part of #984 (flags refresh failing on cellular). Stacked on #1667 (socle). Telemetry only: the refresh, navigation, MP badge and mutations behave exactly as before; no new request, no new Android permission.

The #984 analysis (Fable and Astra, 15/11) could not tell the competing explanations apart with the current exports. This adds what was missing:

  • Foreground state at the start and the end of each flags refresh, plus the transitions during it (bounded relative timeline). In the 14/11 cellular export, two of the four failed refreshes ran almost entirely in the background; this makes that visible.
  • Network events during an active refresh: availability, loss, validated and transport changes, data saver and battery saver at start. One shared callback, registered only while a refresh runs, always unregistered in finally. No SSID, carrier, address or network id is exported.
  • Errno category of failed connection attempts (refused, unreachable, network down, timeout, other), read from a bounded cause chain, never from exception messages.
  • MP badge vs navigation: forum1.php?cat=prive gets its own html:mp-list family, and the unread-badge poll carries an mp-badge intent, so a badge refresh is no longer read as user navigation (the 14/11 "navigation stuck in the burst" was most likely the badge).
  • Isolated successful calls: a bounded sample (two per minute) of calls that overlap nothing for their whole duration, to measure a lone connection on the same network.
  • Calls versus connection attempts per refresh.

Docs: docs/guides/diagnostics.md lists the new fields and their limits.

Validation

Rebased on the socle

  • Only conflict: two tests added at the same place in FlagRefreshDiagnosticsTest; both kept.

PR générée par Claude (Opus 5.5) à la demande de @xatrix.

🤖 Generated with Claude Code

https://claude.ai/code/session_01X7pvomKHW15zFqZ5T6WA6a

@XaaT XaaT added this to the Infra & dette milestone Nov 16, 2026
@XaaT
XaaT force-pushed the feat/984-p2a-telemetry branch from 3110602 to 89a5605 Compare November 16, 2026 20:29
@XaaT
XaaT changed the base branch from dev to feat/984-socle November 16, 2026 20:29
Base automatically changed from feat/984-socle to dev November 16, 2026 20:30
@XaaT
XaaT changed the base branch from feat/984-socle to dev November 16, 2026 20:30
… MP badge family (#984)

Add the telemetry the #984 analysis found missing, without touching the
flags repository logic:

- foreground/background state at the start and end of each flags refresh,
  plus the transitions during it (bounded relative timeline);
- network events during an active refresh (availability, loss, validated
  and transport changes, data saver and battery saver at start), from a
  shared callback registered only while a refresh runs and always
  unregistered in finally; no SSID, carrier, address or network id;
- closed errno categories for failed connection attempts (refused,
  unreachable, network down, timeout, other), read from a bounded cause
  chain, never from exception messages;
- a distinct html:mp-list family for forum1.php?cat=prive and an mp-badge
  intent on the unread-badge poll, so a badge refresh is no longer read as
  user navigation;
- a bounded sample of isolated successful calls outside refresh bursts
  (two per minute, overlap tracked for the whole call);
- per-refresh counts of calls versus connection attempts.

Docs: diagnostics guide lists the new fields and their limits.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01X7pvomKHW15zFqZ5T6WA6a
@XaaT
XaaT force-pushed the feat/984-p2a-telemetry branch 2 times, most recently from d0a74e7 to a25a8fd Compare November 16, 2026 20:48
…e-batch merge (#984)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01X7pvomKHW15zFqZ5T6WA6a
@XaaT
XaaT force-pushed the feat/984-p2a-telemetry branch from a25a8fd to 08bd4e1 Compare November 16, 2026 21:00
@XaaT
XaaT merged commit 0b783d7 into dev Nov 16, 2026
7 checks passed
@XaaT
XaaT deleted the feat/984-p2a-telemetry branch November 16, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant