Repository navigation
feat(diagnostics): anonymous connection test in Diagnostics (#984) - #1669
Merged
Merged
Conversation
XaaT
force-pushed
the
feat/984-p2b-network-test
branch
from
November 16, 2026 20:29
b3b67d4 to
d7b46e8
Compare
XaaT
force-pushed
the
feat/984-p2a-telemetry
branch
from
November 16, 2026 20:29
3110602 to
89a5605
Compare
XaaT
force-pushed
the
feat/984-p2b-network-test
branch
from
November 16, 2026 20:30
d7b46e8 to
e5784f9
Compare
XaaT
force-pushed
the
feat/984-p2a-telemetry
branch
from
November 16, 2026 20:30
89a5605 to
4ecfdaa
Compare
XaaT
force-pushed
the
feat/984-p2b-network-test
branch
2 times, most recently
from
November 16, 2026 20:34
b79dddd to
d248554
Compare
XaaT
force-pushed
the
feat/984-p2a-telemetry
branch
from
November 16, 2026 20:48
d0a74e7 to
a25a8fd
Compare
XaaT
force-pushed
the
feat/984-p2b-network-test
branch
2 times, most recently
from
November 16, 2026 21:00
f857c8c to
38e2a59
Compare
XaaT
force-pushed
the
feat/984-p2a-telemetry
branch
from
November 16, 2026 21:00
a25a8fd to
08bd4e1
Compare
… 20 (#984) Diagnostics gets a "Tester la connexion" button that sends 36 anonymous requests to the public REST catalogue, in waves of 1, 5, 10 and 20, each wave finished before the next and capped at 12 s, to measure the user's connection without any account data. - Dedicated client: HTTP/1.1, no cookie jar, no auth, no cache, no interceptors, fresh connection per call, no application retry. - Per request: TCP, TLS, headers received, first body byte available, total, outcome and errno class (P2a classifier). - Refused while a flags refresh runs; one run at a time; at most one per minute through a persisted reservation that survives rotation, process restart and clock changes; cancelled when the screen closes. - Concurrent HFR traffic marks the measure as disturbed. - Export: one structured entry per wave plus a summary. - No control host yet (extension point only, disabled). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X7pvomKHW15zFqZ5T6WA6a
…ed DNS, count image traffic (#984) Fixes from the P2b gate: - A network-level guard allows one HTTP exchange per probe call, so OkHttp's own follow-ups (408, 503 with Retry-After: 0) can no longer exceed 36. - The probe resolves DNS on a dedicated executor bounded by the wave deadline; cancellation or the deadline releases the refresh lease even if a native resolver stays blocked. - The probe client drops its read and call timeouts: the 12 s wave owns the deadline, so no response is reported as DEADLINE. - Image downloads from HFR now count as concurrent traffic for the "disturbed" flag (no URL exported, image telemetry unchanged). - The export states that tcpMs includes a proxy CONNECT. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X7pvomKHW15zFqZ5T6WA6a
…ollow-up, closed DNS and limit categories (#984) - feature:flags declares activity-compose (LocalActivity was only reachable through an old transitive version). - The probe's network interceptor strips Retry-After from 503 responses, so OkHttp never reopens a connection for a follow-up (36 connections, not 37). - DNS failures and the exchange-limit guard export closed categories (dns_error, exchange_limit) instead of errno=other. - The wave cap is injectable for tests (production stays 12 s). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X7pvomKHW15zFqZ5T6WA6a
… in the connection test (#984) Seen on the emulator: - Plurals for requests, successes and failures ("1 réussite"). - Non-breaking spaces keep "médiane : 624 ms" together. - Order: test state, wave results, warning, then the next-test countdown. - Diagnostics header: title on its own line, actions in resources, no word split ("Ferme/r"). - Button text aligned with the screen's paragraphs. - diagnostics_empty wording shared with the strategies branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X7pvomKHW15zFqZ5T6WA6a
XaaT
force-pushed
the
feat/984-p2b-network-test
branch
from
November 16, 2026 21:15
38e2a59 to
5163825
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #984 (flags refresh failing on cellular). Stacked on #1668 (P2a telemetry). Adds a "Tester la connexion" button in Diagnostics to measure a tester's connection with the same kind of requests the flags refresh makes.
What it does
Retry-Afterfrom 503 responses, so OkHttp's own follow-ups (408, 503) can never exceed 36 exchanges or 36 connections.dns_error,exchange_limit).forum.hardware.frincluded, marks the measure as disturbed (no URL exported).No new Android permission. Strings in resources, formal "vous".
Validation
5a738547d: GREEN, 7 649 tests, 0 failure; after the UI pass,b3b67d4cf: 7 656 tests, only the known flakyMessageCardReadingParityTest(Test instable : MessageCardReadingParityTest > body stays selectable after a full width toggle #1646, outside this diff) failed.activity-composedeclaration, 503 reconnection, closed DNS/limit categories) → Fable GO with reservations.forum-images.hardware.fr(smileys, avatars) is not counted as concurrent traffic; a native resolver that never returns can leave up to 36 daemon threads per run.Rebased on the socle and P2a
DefaultFlagRepository: the socle reads (bounded category fetch and sticky sweep) now run insiderefreshDiagnostics.withRefresh, as the pre-socle reads did. A refresh started while a connection test runs waits for the test to end, and that wait counts against the 12 s collection deadline.PR générée par Claude (Opus 5.5) à la demande de @xatrix.
🤖 Generated with Claude Code
https://claude.ai/code/session_01X7pvomKHW15zFqZ5T6WA6a